Skip to content

Conversation

@appleJax
Copy link
Contributor

@appleJax appleJax commented Sep 5, 2016

What's in this PR?

Added a light gray background to the site footer. It's a small change, but it really differentiates the footer, especially on mobile.

screen shot 2016-09-04 at 8 43 19 pm

Here it is on mobile (note: this screenshot is from a different branch that has a responsive layout):

screen shot 2016-09-04 at 11 36 31 pm

@npendery
Copy link
Contributor

npendery commented Sep 8, 2016

LGTM! :shipit:

@olegko
Copy link

olegko commented Sep 8, 2016

digging the color background change.. good to separate it from the rest of the page. The only time it may look awkward is on a short page (so footer would take up majority of real estate).

not a big fan of the single column format in footer though, thoughts?

@appleJax
Copy link
Contributor Author

appleJax commented Sep 8, 2016

@olegko not 100% sold on the single column footer, but keep in mind that layout is for phones. Similar to heroku.com, codeschool.com ...

@ivy-g
Copy link
Contributor

ivy-g commented Sep 8, 2016

@olegko I was thinking that as well. It may work as two columns, left aligned. Social links could be icon only across the bottom

@ivy-g
Copy link
Contributor

ivy-g commented Sep 8, 2016

are we planning to add links to the "help" and "learn" sections? Otherwise, subtitles seem unnecessary

@appleJax
Copy link
Contributor Author

appleJax commented Sep 8, 2016

@ivy-g good point, maybe we should make the subtitles themselves be links to the email and blog instead of having redundant links?

@rileytaylor
Copy link
Contributor

The single column is how a lot of people go about it on mobile. But we should explore double column options and even a simplified footer. I like the idea of icons only for social.

@ivy-g
Copy link
Contributor

ivy-g commented Sep 8, 2016

if we took out the subtitles and simplified the social section, it might look cleaner as a single column.

@ivy-g
Copy link
Contributor

ivy-g commented Sep 8, 2016

@appleJax i agree, making help an email link and learn link to the blog might be a lot nicer

@npendery
Copy link
Contributor

npendery commented Sep 8, 2016

Just want to put in that we should create an issue for general footer formatting improvements for both web and mobile views. I think that this is a good discussion and should be retained for further improvements and not removed once this small change gets merged

@appleJax
Copy link
Contributor Author

appleJax commented Sep 8, 2016

Yeah, I just realized most of this discussion actually has nothing to do with the gray background, which is the only change this PR makes, lol. All great stuff though, maybe we should move this discussion to PR #418

@ivy-g
Copy link
Contributor

ivy-g commented Sep 8, 2016

@appleJax agreed

@appleJax
Copy link
Contributor Author

appleJax commented Sep 8, 2016

So yay or nay on the gray background?

@ivy-g
Copy link
Contributor

ivy-g commented Sep 8, 2016

yay

@appleJax
Copy link
Contributor Author

appleJax commented Sep 8, 2016

@npendery @olegko @rileytaylor @WenInCode @joshsmith ?

yay: 2
nay: 0

@WenInCode
Copy link
Contributor

I like it

@appleJax
Copy link
Contributor Author

appleJax commented Sep 8, 2016

Ok, I think we have a majority vote to add the gray background. Permission to merge?

@WenInCode
Copy link
Contributor

:shipit:

@appleJax appleJax merged commit 6ce7b67 into code-corps:develop Sep 8, 2016
@appleJax appleJax deleted the gray-footer branch September 8, 2016 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants