Fix ESLint offences Round 2 #599
Conversation
http://eslint.org/docs/rules/key-spacing enforce consistent spacing between keys and values in object literal properties This rule enforces spacing around the colon in object literal properties. It can verify each property individually, or it can ensure horizontal alignment of adjacent properties in an object literal.
joshsmith
left a comment
joshsmith
left a comment
There was a problem hiding this comment.
Approval for the subset of things this tackles (key-spacing)
|
@sarupbanskota there are some merge conflicts here. Can you rebase? |
|
Hey @sarupbanskota, just checking in! |
|
sorry again! I'll be back on it this weekend! :) |
…-access, no-const-outside-module-scope, block-spacing, no-multiple-empty-lines, comma-spacing, space-before-function-paren, prefer-template, dot-notation, object-curly-spacing, operator-linebreak, space-infix-ops, keyword-spacing, max-statements-per-line, brace-style, single-quotes, object-short-hand, spaced-comments, and comma-dangle
…p and organization properties to organization ability
…, adds unit tests and documentation for new mixin.
- Moves from `module` to `moduleForAcceptance` - Adds `server.shutdown` to integration tests using Mirage Minor changes: - Remove unused packages from bower.json - Upgrade ember-concurrency - Upgrade ember-page-title - Update some minor Mirage file changes
- also fixed 2 test failures caused by default tooltip class name change
update remaining integration tests to use service helper
|
@sarupbanskota it looks like something went weird with your rebase. |
|
I have a bad feeling this PR might need to be closed. The history looks like it's really off now. |
|
yep! :-( I'm sorry folks. I'll start another PR! |
|
sorry folks, back with the cliche excuse - got really busy with $DAYJOB, sigh! Closing this and made progress on #653 I've enforced horizontal alignment for JSON - y'all should like it :) |
|
@sarupbanskota no need to apologize! I totally understand. I just feel bad when things get outdated for you. |
9 participants
This is a WIP PR
Make sure any changes to code include changes to documentation.
References
Fixes #
Progress on: #
http://eslint.org/docs/rules/key-spacing
enforce consistent spacing between keys and values in object literal properties
This rule enforces spacing around the colon in object literal properties.
It can verify each property individually, or it can ensure horizontal
alignment of adjacent properties in an object literal.