Skip to content

WIP: Use page objects for user-skills-input-test #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2017
Merged

WIP: Use page objects for user-skills-input-test #908

merged 1 commit into from
Jan 25, 2017

Conversation

@sarupbanskota
Copy link
Contributor

@sarupbanskota sarupbanskota commented Dec 22, 2016 •
edited by joshsmith
Loading

Closes #778
Also under #697

@sarupbanskota sarupbanskota force-pushed the tests/page-object-user-skills-input branch from 627c65f to a8eb988 Compare December 22, 2016 18:03
sarupbanskota
sarupbanskota commented Dec 22, 2016
View reviewed changes
tests/integration/components/user-skills-input-test.js
beforeEach() {
stubService(this, 'store', mockStore);
stubService(this, 'user-skills', mockUserSkillsService);
page.setContext(this);
Copy link
Contributor Author

@sarupbanskota sarupbanskota Dec 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this in based on what the error on the test logs suggested, but I didn't quite understand what happened here?

The tests pass with this.

@sarupbanskota
Copy link
Contributor Author

sarupbanskota commented Dec 23, 2016

@joshsmith I think with the exception of the last commit, it's pretty much in ready state.

I'd appreciate help with my last commit - I'm not too sure what Page Objects property to use to get the html() of an element, since text() only seems to pull out underlying text.

Maybe as a final step I'll look at chaining some of the page.method calls too.

Let me know!

@sarupbanskota sarupbanskota force-pushed the tests/page-object-user-skills-input branch from e380ce3 to 3bf70b6 Compare December 25, 2016 11:04
@joshsmith
Copy link
Contributor

joshsmith commented Dec 29, 2016

@sarupbanskota I wouldn't use .html() here; see that PR I did that treats strong elements as a collection.

@joshsmith joshsmith force-pushed the tests/page-object-user-skills-input branch from 3bf70b6 to 896c705 Compare January 25, 2017 22:26
@joshsmith joshsmith requested review from begedin and removed request for joshsmith January 25, 2017 22:27
begedin
begedin approved these changes Jan 25, 2017
View reviewed changes
Copy link
Contributor

@begedin begedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though I'm still unhappy with my understanding of how wait works.

@joshsmith joshsmith force-pushed the tests/page-object-user-skills-input branch from 896c705 to 3282389 Compare January 25, 2017 22:44
@joshsmith joshsmith merged commit fa393d3 into develop Jan 25, 2017
@joshsmith joshsmith deleted the tests/page-object-user-skills-input branch January 25, 2017 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@begedin begedin begedin approved these changes

Assignees

@joshsmith joshsmith

@sarupbanskota sarupbanskota

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sarupbanskota @joshsmith @begedin