Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions app/routes/project/tasks/new.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,20 @@ export default Route.extend(AuthenticatedRouteMixin, {
this.controllerFor('project.tasks.new').set('error', error);
}
});
},

willTransition(transition) {
let task = get(this, 'controller.task');

// prompt to confirm if the user did not save
if (get(task, ('isNew'))) {
let confirmed = window.confirm('You will lose any unsaved information if you leave this page. Are you sure?');
if (confirmed) {
task.destroyRecord();
} else {
transition.abort();
}
}
}
}
});
68 changes: 68 additions & 0 deletions tests/acceptance/task-creation-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import Mirage from 'ember-cli-mirage';
import loginPage from '../pages/login';
import projectTasksIndexPage from '../pages/project/tasks/index';
import projectTasksNewPage from '../pages/project/tasks/new';
import sinon from 'sinon';

moduleForAcceptance('Acceptance | Task Creation');

Expand Down Expand Up @@ -228,3 +229,70 @@ test('When task creation fails due to non-validation issues, the error is displa
assert.equal(projectTasksNewPage.errors().contains('An unknown error: Something happened', 'The error is messaged'), true);
});
});

test('Navigating away from task route destroys task with prompt', function(assert) {
assert.expect(3);

let user = server.schema.users.create({ username: 'test_user' });

let project = createProjectWithSluggedRoute();
let { organization } = project;
project.createTaskList({ inbox: true });

authenticateSession(this.application, { user_id: user.id });
projectTasksIndexPage.visit({ organization: organization.slug, project: project.slug });

andThen(() => {
projectTasksIndexPage.clickNewTask();
});

let stub = sinon.stub(window, 'confirm', () => {
assert.ok(true, 'Confirmation prompt was called.');
return true;
});

andThen(() => {
projectTasksNewPage.projectMenu.tasksLink.click();
});

andThen(() => {
assert.equal(
projectTasksIndexPage.taskBoard.taskLists(0).taskCards().count,
0,
'The task was removed from the list.'
);
assert.equal(currentRouteName(), 'project.tasks.index', 'Navigation was successful.');
stub.restore();
});
});

test('Navigation is aborted if user answers negatively to prompt', function(assert) {
assert.expect(2);

let user = server.schema.users.create({ username: 'test_user' });

let project = createProjectWithSluggedRoute();
let { organization } = project;
project.createTaskList({ inbox: true });

authenticateSession(this.application, { user_id: user.id });
projectTasksIndexPage.visit({ organization: organization.slug, project: project.slug });

andThen(() => {
projectTasksIndexPage.clickNewTask();
});

let stub = sinon.stub(window, 'confirm', () => {
assert.ok(true, 'Confirmation prompt was called.');
return false;
});

andThen(() => {
projectTasksNewPage.projectMenu.tasksLink.click();
});

andThen(() => {
assert.equal(currentRouteName(), 'project.tasks.new', 'Navigation was aborted.');
stub.restore();
});
});
8 changes: 7 additions & 1 deletion tests/pages/components/task-board.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
import { collection } from 'ember-cli-page-object';
import taskListCards from 'code-corps-ember/tests/pages/components/task-list-cards';

export default {
scope: '.task-board'
scope: '.task-board',
taskLists: collection({
item: taskListCards
})
};
9 changes: 6 additions & 3 deletions tests/pages/project/tasks/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@ import {
create,
visitable
} from 'ember-cli-page-object';
import projectDetails from '../../components/project-details';
import projectMenu from '../../components/project-menu';
import projectDetails from 'code-corps-ember/tests/pages/components/project-details';
import projectMenu from 'code-corps-ember/tests/pages/components/project-menu';
import taskBoard from 'code-corps-ember/tests/pages/components/task-board';

export default create({
visit: visitable(':organization/:project/tasks'),
Expand All @@ -22,7 +23,9 @@ export default create({
},

clickNewTask: clickable('.new-task'),
clickCancel: clickable('.cancel'),

projectDetails,
projectMenu
projectMenu,
taskBoard
});
15 changes: 9 additions & 6 deletions tests/pages/project/tasks/new.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,22 +6,25 @@ import {
visitable
} from 'ember-cli-page-object';

export default create({
visit: visitable(':organization/:project/tasks/new'),
import projectMenu from 'code-corps-ember/tests/pages/components/project-menu';

export default create({
clickPreviewTask: clickable('.preview'),
clickSubmit: clickable('[name=submit]'),

errors: collection({
scope: '.error'
}),

taskTitle: fillable('[name=title]'),
taskMarkdown: fillable('[name=markdown]'),
taskType: fillable('[name=task-type]'),

clickSubmit: clickable('[name=submit]'),
projectMenu,

previewBody: {
scope: '.body-preview'
},

errors: collection({
scope: '.error'
})
visit: visitable(':organization/:project/tasks/new')
});