Skip to content

Conversation

@RiceViz
Copy link
Contributor

@RiceViz RiceViz commented Aug 28, 2025

This Pull Request Implements the Media Item function inside my own loader and also the extra credit to implement the credits for each Media Item

What I Learned:

  • I learned how to implement .csv files inside of typescript/javascript files
  • I learned different functions like createReadStream() within typescript

Challenges:

  • How to combine different .csv file and database rows into each other through code
  • Loading the data properly so it reads the .csv file

@RiceViz RiceViz changed the title feat: adds Tyran's media items functionality and combines with credits feat: adds Tyran's Lesson 10 media items functionality and combines with credits Aug 29, 2025
Copy link
Contributor

@anthonydmays anthonydmays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎓 Automated Grading Report

Student: Tyran Rice
Date: 8/29/2025

Feedback

Tyran Rice's submission demonstrates a solid understanding of the task requirements, with a few areas for improvement. Functionally, the loader correctly implements the Loader interface and includes the necessary methods to load media items and credits. The loadMediaItems() method successfully parses the CSV file and creates MediaItem objects with the correct properties. However, the submission does not explicitly verify the correct distribution of media types or ensure exactly 200 media items are loaded, which is a critical requirement. Technically, the TypeScript code is well-structured and follows naming conventions, with the file named tyranricejr_loader.ts. All GitHub checks have passed, indicating that the code is technically sound. However, the submission could benefit from more explicit error handling and validation of the media type distribution. For the stretch goal, the loadData() method effectively combines media items with credits, but it does not explicitly ensure that exactly 100 media items have credits attached. Overall, the submission is strong but could be improved with additional checks and validations to fully meet all requirements.


This is an automated preliminary review. Please review and adjust before finalizing.

anthonydmays
anthonydmays previously approved these changes Sep 4, 2025
@anthonydmays anthonydmays merged commit b37947e into code-differently:main Sep 4, 2025
1 check passed
@RiceViz RiceViz deleted the feat/lesson_10/loader branch September 8, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants