Shrink main.js from webpack by using externals #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpirich
requested review from
bethanyaconnor,
breville,
davidsbailey and
maddiedierker
davidsbailey
approved these changes
Nov 23, 2019
Member
davidsbailey
left a comment
davidsbailey
left a comment
There was a problem hiding this comment.
Looks good, thanks for tackling this @cpirich !
If you want to optimize further and run out of things that are shared with existing code studio bundles, then another option is to split some of the larger dependencies into a separate file so they can be loaded in parallel. Here is an example of how we did this on code studio pages: code-dot-org/code-dot-org#30374
| "lodash": "^4.17.5", | ||
| "radium": "^0.25.2", | ||
| "react": "~15.4.0", | ||
| "react-dom": "~15.4.0" |
Member
There was a problem hiding this comment.
Heads up @jmkulwik that if you bump the react version to 15.6 in our main repo, that you may need to bump these too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main.js(used within Code Studio) by 34%: from 9885072 bytes to 6546734 bytes by keeping four packages out of our bundle and labeling them asexternals:lodash,radium,react, andreact-dom. These are now listed aspeerDependenciesby our package, indicating that we expect anyone linking our package to also link those packages alongsideml-activitiesproduction(main.js) when runningyarn start- we only do this when runningyarn buildnowpackage.json: jquery-ui-touch-punch, jquery-ui, react-bootstrap, react-colorwebpack-bundle-analyzeras a devDependency so we can easily invoke it if we want to understand our bundle (and generate pretty pictures like the ones below)Before:
After:
