Skip to content

Shrink main.js from webpack by using externals #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2019
Merged

Shrink main.js from webpack by using externals #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,12 @@
},
"author": "",
"license": "Apache-2.0",
"peerDependencies": {
"lodash": "^4.17.5",
"radium": "^0.25.2",
"react": "~15.4.0",
"react-dom": "~15.4.0"
Copy link
Member

@davidsbailey davidsbailey Nov 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heads up @jmkulwik that if you bump the react version to 15.6 in our main repo, that you may need to bump these too.

},
"devDependencies": {
"@tensorflow-models/knn-classifier": "~1.1.0",
"@tensorflow-models/mobilenet": "^2.0.4",
Expand Down Expand Up @@ -55,23 +61,20 @@
"identity-obj-proxy": "^3.0.0",
"jest": "^15.0.0",
"jquery": "1.12.1",
"jquery-ui": "^1.12.1",
"jquery-ui-touch-punch": "^0.2.3",
"lodash": "^4.17.5",
"mem": ">=4.0.0",
"node-fetch": "^2.6.0",
"prettier": "1.16.1",
"query-string": "4.1.0",
"radium": "^0.25.2",
"react": "~15.4.0",
"react-bootstrap": "0.30.1",
"react-color": "^2.17.3",
"react-dom": "~15.4.0",
"react-test-renderer": "~15.4.0",
"style-loader": "^1.0.0",
"svm": "uponthesun/svmjs",
"url-loader": "^2.2.0",
"webpack": "4.19.1",
"webpack-bundle-analyzer": "^3.6.0",
"webpack-cli": "^3.3.6",
"webpack-dev-server": "^3.1.4",
"yargs": "^14.0.0"
Expand Down
59 changes: 52 additions & 7 deletions webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,11 @@
const { CleanWebpackPlugin } = require('clean-webpack-plugin');
const CopyPlugin = require('copy-webpack-plugin');

module.exports = {
const commonConfig = {
devtool: 'eval-cheap-module-source-map',
resolve: {
extensions: ['.js', '.jsx'],
},
entry: {
assetPath: './src/demo/assetPath.js',
main: './src/index.js',
demo: './src/demo/index.jsx',
},
output: {
filename: '[name].js',
libraryTarget: 'umd',
Expand Down Expand Up @@ -76,7 +71,10 @@ module.exports = {
},
maxAssetSize: 300000,
maxEntrypointSize: 10500000,
},
}
};

const firstConfigOnly = {
plugins: [
new CleanWebpackPlugin(),
new CopyPlugin([{
Expand All @@ -86,3 +84,50 @@ module.exports = {
}]),
],
};

const externalConfig = {
externals: {
"lodash": "lodash",
"radium": "radium",
"react": "react",
"react-dom": "react-dom",
}
};

const defaultConfig = [
{
entry: {
assetPath: './src/demo/assetPath.js'
},
...commonConfig,
...firstConfigOnly,
...externalConfig
},
{
entry: {
demo: './src/demo/index.jsx'
},
...commonConfig
}
];

const productionConfig = [
{
entry: {
main: './src/index.js'
},
...commonConfig,
...externalConfig
}
];

module.exports = (env, argv) => {
if (argv.mode === 'production') {
return [
...defaultConfig,
...productionConfig,
];
}

return defaultConfig;
};
Loading