Skip to content

The one with fixes for deferred values#135

Merged
AlemTuzlak merged 1 commit intomainfrom
134-server-crash-when-exception-thrown-during-deferred-data
Jun 20, 2024
Merged

The one with fixes for deferred values#135
AlemTuzlak merged 1 commit intomainfrom
134-server-crash-when-exception-thrown-during-deferred-data

Conversation

@AlemTuzlak
Copy link
Copy Markdown
Contributor

@AlemTuzlak AlemTuzlak commented Jun 20, 2024

Description

Deferred values, if thrown, would crash the server, this is now not the case and is handled internally, extra error logs are logged for each key and why it failed

Fixes #134

If this is a new feature please add a description of what was added and why below:

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit tests

Checklist:

  • My code follows the guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@AlemTuzlak AlemTuzlak linked an issue Jun 20, 2024 that may be closed by this pull request
@AlemTuzlak AlemTuzlak merged commit 889f76e into main Jun 20, 2024
@AlemTuzlak AlemTuzlak deleted the 134-server-crash-when-exception-thrown-during-deferred-data branch June 20, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Server crash when exception thrown during deferred data

1 participant