Skip to content

Use Inherit To Preserve Text Color#136

Merged
AlemTuzlak merged 1 commit intocode-forge-io:mainfrom
ecline123:inherit-text-color
Jun 27, 2024
Merged

Use Inherit To Preserve Text Color#136
AlemTuzlak merged 1 commit intocode-forge-io:mainfrom
ecline123:inherit-text-color

Conversation

@ecline123
Copy link
Copy Markdown
Contributor

@ecline123 ecline123 commented Jun 25, 2024

Description

Browser defaults or project overrides for text color can cause the UI to become nearly unreadable when color is set to use initial values.
Screenshot 2024-06-25 at 2 15 28 PM

Switching the color to use inherit (which is used everywhere else in the css), resolves the issue.
Screenshot 2024-06-25 at 2 15 43 PM

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Verified before and after changes that the UI looks correct and that the issue is resolved, in Chrome, Firefox, and Safari.

Checklist:

  • My code follows the guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Copy Markdown
Contributor

@AlemTuzlak AlemTuzlak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANK YOU so much for this, I've been meaning to fix this for a while now and I always keep forgetting.

@AlemTuzlak AlemTuzlak merged commit ac2a548 into code-forge-io:main Jun 27, 2024
@ecline123 ecline123 deleted the inherit-text-color branch June 27, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants