Skip to content

Conversation

@ptomulik
Copy link
Contributor

This makes my test.tar.gz to work, so I believe it fixes #18. To test it, please tar -xzf test.tar.gz && cd test/ && doctum.phar update --force -v docs/doctum-relative.conf.php (using doctum.phar generated from this PR).

@williamdes williamdes added this to the v5.3.1 milestone Dec 21, 2020
@williamdes williamdes added the bug Something isn't working label Dec 21, 2020
@williamdes williamdes self-assigned this Dec 21, 2020
Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯
I will add your tests to have integration tests on this project

@williamdes
Copy link
Member

By the way do you have a GPG key ?

@ptomulik
Copy link
Contributor Author

ptomulik commented Dec 22, 2020

By the way do you have a GPG key ?

Not ATM. I mean I used GPG key(s) for email but it got me a lot of headache one day my signature expired, so I just abandoned my GPGs for a moment :)

@williamdes
Copy link
Member

Not ATM. I mean I used GPG key(s) for email but it got me a lot of headache one day my signature expired, so I just abandoned my GPGs for a moment :)

If you still have the private key you can extend the expiration date and use them ;)
This can be useful to upload the key: https://gist.github.com/williamdes/0d49288fecf83bf491cc1e6366ae7c30#upload-the-key
I can help you if you want, let 2021 be a year with a working key to sign commits and tags ;p

@williamdes
Copy link
Member

@williamdes williamdes merged commit 241cb84 into code-lts:main Dec 22, 2020
@williamdes williamdes changed the title attempt fixing #18 Fix #18 Make releative paths work using phars Dec 22, 2020
@williamdes
Copy link
Member

5.3.1 is out with your fix, thank you !

@ptomulik ptomulik deleted the issue-18 branch December 30, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Development

Successfully merging this pull request may close these issues.

PHAR fails when relative cache || build path is used

2 participants