Skip to content

chore(tips): localize minimum threshold against selected currency; no… #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmc08gt merged 1 commit into from
May 21, 2024
Merged

chore(tips): localize minimum threshold against selected currency; no… #407

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions app/src/main/java/com/getcode/view/main/tip/TipPaymentViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,17 +86,18 @@ class TipPaymentViewModel @Inject constructor(
}
}

private val minUsdLimit: Kin
get() {
return KinAmount.fromFiatAmount(minUsdFiatLimit, exchange.rateForUsd()!!).kin
private val minLimit: (rate: Rate) -> Kin = { rate ->
KinAmount.fromFiatAmount(minFiatLimit(rate), rate).kin
}

private val maxFiatLimit: (rate: Rate) -> Double = { rate ->
(transactionRepository.sendLimitFor(rate.currency) ?: SendLimit.Zero).nextTransaction
}

private val minUsdFiatLimit: Double
get() = (transactionRepository.sendLimitFor(CurrencyCode.USD) ?: SendLimit.Zero).maxPerTransaction / 250.0
private val minFiatLimit: (rate: Rate) -> Double = { rate ->
(transactionRepository.sendLimitFor(rate.currency)
?: SendLimit.Zero).maxPerTransaction / 250.0
}


private val hasAvailableTransactionLimit: (amount: KinAmount, rate: Rate) -> Boolean = { amount, _ ->
Expand All @@ -111,7 +112,7 @@ class TipPaymentViewModel @Inject constructor(
get() = transactionRepository.hasAvailableDailyLimit()

private val isTipLargeEnough: (amount: KinAmount) -> Boolean = { amount ->
amount.kin >= minUsdLimit
amount.kin >= minLimit(amount.rate)
}

suspend fun onSubmit(): KinAmount? {
Expand Down Expand Up @@ -160,7 +161,7 @@ class TipPaymentViewModel @Inject constructor(

if (!isTipLargeEnough(amount)) {
// min amount is based on send limit for USD
val kin = KinAmount.fromFiatAmount(minUsdFiatLimit, exchange.rateForUsd()!!).kin
val kin = KinAmount.fromFiatAmount(minFiatLimit(amount.rate), amount.rate).kin
// convert min amount in USD to selected currency
val normalizedAmount = KinAmount.newInstance(kin, rate)
// format for display
Expand Down