Skip to content

chore: improve error typing for submit Intent failures #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmc08gt merged 1 commit into from
Jun 20, 2024
Merged

chore: improve error typing for submit Intent failures #474

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions api/src/main/java/com/getcode/network/repository/TransactionRepository.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -722,14 +722,32 @@ class TransactionRepository @Inject constructor(

sealed class ErrorSubmitIntent(val value: Int) {
data class Denied(val reasons: List<DeniedReason> = emptyList()): ErrorSubmitIntent(0)
data object InvalidIntent: ErrorSubmitIntent(1)
data class InvalidIntent(val reasons: List<String>): ErrorSubmitIntent(1)
data object SignatureError: ErrorSubmitIntent(2)
data object StaleState: ErrorSubmitIntent(3)
data class StaleState(val reasons: List<String>): ErrorSubmitIntent(3)
data object Unknown: ErrorSubmitIntent(-1)
data object DeviceTokenUnavailable: ErrorSubmitIntent(-2)

override fun toString(): String {
return when (this) {
is Denied -> "denied(${reasons.joinToString()})"
DeviceTokenUnavailable -> "deviceTokenUnavailable"
is InvalidIntent -> "invalidIntent(${reasons.joinToString()})"
SignatureError -> "signatureError"
is StaleState -> "staleState(${reasons.joinToString()})"
Unknown -> "unknown"
}
}

companion object {
operator fun invoke(proto: SubmitIntentResponse.Error): ErrorSubmitIntent {
val reasonStrings = proto.errorDetailsList.mapNotNull {
when (it.typeCase) {
TransactionService.ErrorDetails.TypeCase.REASON_STRING ->
it.reasonString.reason.takeIf { reason -> reason.isNotEmpty() }
else -> null
}
}
return when (proto.code) {
SubmitIntentResponse.Error.Code.DENIED -> {
val reasons = proto.errorDetailsList.mapNotNull {
Expand All @@ -739,9 +757,9 @@ class TransactionRepository @Inject constructor(

Denied(reasons)
}
SubmitIntentResponse.Error.Code.INVALID_INTENT -> InvalidIntent
SubmitIntentResponse.Error.Code.INVALID_INTENT -> InvalidIntent(reasonStrings)
SubmitIntentResponse.Error.Code.SIGNATURE_ERROR -> SignatureError
SubmitIntentResponse.Error.Code.STALE_STATE -> StaleState
SubmitIntentResponse.Error.Code.STALE_STATE -> StaleState(reasonStrings)
SubmitIntentResponse.Error.Code.UNRECOGNIZED -> Unknown
else -> return Unknown
}
Expand Down