fix: make gRPC observers waitForReady#581
Merged
bmc08gt merged 2 commits intorelease/2.1.13from Oct 7, 2024
Merged
Conversation
…being cancelled if one fails This affected probably n number of things when this was recently converted away from a ViewModel into a standalone Singleton to support SessionController (previously HomeViewModel) usage outside of just the camera screen (e.g chat). The scoping that existed in it, however, didn't associate a supervisor Job so a generic one was established. This had the adverse affects of cancelling any and all running job's within the scope if one inadvertently failed for any reason. This impacted cash link receiving as a byproduct. Setup a supervisor job, on the IO thread, to alleviate the issue and allow child jobs to fail independently as expected. Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
bmc08gt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This affected probably n number of things when this was recently converted away from a ViewModel into a standalone Singleton to support SessionController (previously HomeViewModel) usage outside of just the camera screen (e.g chat). The scoping that existed in it, however, didn't associate a supervisor Job so a generic one was established. This had the adverse affects of cancelling any and all running job's within the scope if one inadvertently failed for any reason. This impacted cash link receiving as a byproduct.
Setup a supervisor job, on the IO thread, to alleviate the issue and allow child jobs to fail independently as expected.