feat(onramp): migrate Phantom integration from manual deeplinks to SDK#713
Merged
Conversation
Replace hand-rolled deeplink protocol (URL building, X25519 key exchange, NaCl encryption, callback activity) with phantom-connect-wallet SDK. - PhantomWalletConnector now drives connect and sign in-process - connectAndSign() handles the full ceremony; signAndSend() covers the deferred-amount path (Token.Info / CurrencyCreator) - Remove manual deeplink parsing, BoxKeyPair, and DeeplinkType routing - Update Hilt module to provide SDK-backed connector - Clean up manifest (callback activity, query intent) Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
github-actions
Bot
added
type: feature
…-migration Resolve conflicts keeping phantom SDK approach (connectAndSign/signAndSend) while adopting code/cash FundingSource enum, requestFlowExit(), and deposit/verification changes. Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
…WalletController Replace the old deeplink state machine (ExternalWalletOnRampController/Handler/State) with PhantomWalletController backed by the phantom-connect-kmp SDK. Uses withCeremony for multi-hop connect+sign flows, keeping the transparent overlay alive across round-trips. Navigation callbacks fire before deeplink launch (matching old emitPendingNavigation pattern) so the host activity renders the target screen before Phantom opens.
…-migration * origin/code/cash: fix(onramp): align Coinbase error codes with official docs and group by UI Remove signingConfig from release build type build: update release manifest chore: move Android SDK constants from buildSrc to version catalog build: bump library compileSdk from 36 to 37 fix(onramp): show region mismatch alert for AssetNotTradableInRegion fix(onramp): pass error data to Throwable and add AssetNotTradableInRegion error chore: clean up R8 keep rules chore: rename BaseViewModel2 to BaseViewModel chore: remove deprecated BaseViewModel build: remove rxjava cleanup agent now that rxjava was removed chore: remove RxJava dependency entirely feat: add project-specific Claude agents chore: commit bug-triage agent and gitignore plans chore: include bug fixes and dependencies in release notes skill build: bump targetSdkVersion to 37 (Android 17) fix: bump wrapper to 9.4.1 fix(services): correct user agent for Flipcash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace hand-rolled deeplink protocol (URL building, X25519 key exchange, NaCl encryption, callback activity) with phantom-connect-wallet SDK.