fix(onramp): dismiss Google Pay sheet on commit_error#742
Merged
Conversation
When a Coinbase commit_error arrives while the Google Pay GMS Activity is on top, nothing dismissed it — the user had to close it manually. Extract the CLEAR_TOP intent trick into dismissPaymentSheet() and call it from wrappedOnPaymentFailure and wrappedOnCancel whenever the payment sheet was presented. Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
bmc08gt
force-pushed
the
fix/dismiss-gpay-on-commit-error
branch
from
297430a to
0e1e760
Compare
bmc08gt
changed the title
github-actions
Bot
added
type: fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a Coinbase commit_error arrives while the Google Pay GMS Activity is on top, nothing dismissed it — the user had to close it manually. Extract the CLEAR_TOP intent trick into dismissPaymentSheet() and call it from wrappedOnPaymentFailure whenever the payment sheet was presented.