feat(home): add nav bar settings sheet with drag-to-reorder#767
Merged
Conversation
Add WrapContentSheet interface, IsWrapContentSheet metadata key, and conditional fillMaxHeight/ScrimOverlay handling for wrap-content sheets. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Extract NavBarButton, GiveButtonLabel, NavBarConfig models and shared NavigationBar composable from scanner. Add LongPressDraggable utility and NavBar feature flag. Refactor ScannerNavigationBar to use shared NavigationBar. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add NavBarSettingsScreen and content with drag-to-reorder support. Register NavBarSettings route, add string resources, wire entry in Labs "Home Screen" section, and register screen in AppScreenContent. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
Bot
added
type: feature
bmc08gt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
Navigation layer — new WrapContentSheet interface in ui/navigation. Sheets implementing this marker skip fillMaxHeight and the ScrimOverlay, allowing content-sized bottom sheets.
Core models — NavBarButton, GiveButtonLabel, and NavBarConfig define the button order and label preferences with serialization for storage in feature flags. The existing inline navigation bar in ScannerNavigationBar is replaced
with the shared NavigationBar composable.
Labs settings — a new "Home Screen" section in Labs opens a NavBarSettingsScreen bottom sheet where users can drag-to-reorder nav buttons and toggle the give-button label between options via a segmented control. Changes persist
immediately through the NavBar feature flag.