feat(phone): dispatch LinkForPayment on verification and onboarding complete#780
Merged
Conversation
Update flipcash protobuf definitions and add service layer stubs for the new LinkForPayment RPC which links a verified phone number for payment. Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
github-actions
Bot
added
area: network
bmc08gt
force-pushed
the
feat/link-for-payment
branch
from
a32011a to
6b4c43a
Compare
…omplete Wire up the LinkForPayment RPC so it fires in two cases: - After phone verification from the send flow (via linkForPayment flag on Verification route) - After onboarding completes (via OnboardingViewModel) Also fix a bug where phone verification was shown during onboarding even when the phone-number-send feature flag was disabled — resolvePostAccountRoute now checks phoneNumberSendEnabled before routing to verification. Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
bmc08gt
force-pushed
the
feat/link-for-payment
branch
from
6b4c43a to
1e0c20e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update flipcash protobuf definitions and add service layer stubs for the
new LinkForPayment RPC which links a verified phone number for payment.
Wire up the LinkForPayment RPC so it fires in two cases:
Also fix a bug where phone verification was shown during onboarding even
when the phone-number-send feature flag was disabled — resolvePostAccountRoute
now checks phoneNumberSendEnabled before routing to verification.