Skip to content

chore(phone): ensure phone textfield is vertically centered #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmc08gt merged 1 commit into from
Jan 24, 2024
Merged

chore(phone): ensure phone textfield is vertically centered #90

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions app/src/main/java/com/getcode/view/login/PhoneVerify.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ import com.getcode.theme.CodeTheme
import com.getcode.theme.White05
import com.getcode.theme.White50
import com.getcode.theme.extraSmall
import com.getcode.util.debugBounds
import com.getcode.util.getActivity
import com.getcode.util.rememberedClickable
import com.getcode.view.components.ButtonState
Expand Down Expand Up @@ -127,7 +128,7 @@ internal fun PhoneVerify(
delay(500)
openCountrySelector()
}
}
},
) {
dataState.countryLocale.resId?.let { resId ->
Image(
Expand All @@ -140,17 +141,18 @@ internal fun PhoneVerify(
contentDescription = "",
)
}
Text(
Box(
modifier = Modifier
.height(CodeTheme.dimens.grid.x12)
.align(CenterVertically)
.padding(
horizontal = CodeTheme.dimens.grid.x3,
vertical = CodeTheme.dimens.grid.x4
),
style = CodeTheme.typography.subtitle1,
text = "+${dataState.countryLocale.phoneCode}"
)
.padding(horizontal = CodeTheme.dimens.grid.x3,),
contentAlignment = Center
) {
Text(
style = CodeTheme.typography.subtitle1,
text = "+${dataState.countryLocale.phoneCode}"
)
}
}
Spacer(
modifier = Modifier
Expand All @@ -162,8 +164,7 @@ internal fun PhoneVerify(
modifier = Modifier
.wrapContentWidth()
.weight(1f)
.focusRequester(focusRequester)
.padding(top = CodeTheme.dimens.grid.x1),
.focusRequester(focusRequester),
value = dataState.phoneNumberFormattedTextFieldValue,
textStyle = CodeTheme.typography.subtitle1.copy(color = CodeTheme.colors.onBackground),
keyboardOptions = KeyboardOptions.Default.copy(keyboardType = KeyboardType.Phone),
Expand Down