Skip to content

Conversation

@matejchalk
Copy link
Collaborator

Error report from customer:

Since this pr #1087 , RunnerConfig.args will have appended at the end of the args, and there is no way (that I found) to opt out of this behaviour 😞

We use the runner config to run knip, with a custom knip reporter that outputs code-puhsup report, but that is no longer working properly:

Before the change, the runner was running :
$ npx knip --no-exit-code --no-progress --config=./knip.config.ts --reporter=./tools/code-pushup-tools/src/plugins/knip/src/reporter/index.ts --reporter-options='{"outputFile":".code-pushup/knip/knip-report-1756801750731.json"}'

And now, it's running :
$ npx knip --no-exit-code --no-progress --config=./knip.config.ts --reporter=./tools/code-pushup-tools/src/plugins/knip/src/reporter/index.ts --reporter-options='{"outputFile":".code-pushup/knip/knip-report-1756801750731.json"}' --outputDir="/Users/nicolasbeaussart-hatchuel/work/payfit/git/hr-apps/.code-pushup/monorepo-root" --filename="report" --format="json" --format="md" --skipReports
But all of the extra options are not recognized by knip 😞

Is there a way to opt out of this breaking change ?

Solved by replacing CLI args with environment variables (prefixed with CP_) so it doesn't conflict with the shell script.

@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 core 🧩 models 🧩 utils labels Sep 3, 2025
@nx-cloud
Copy link

nx-cloud bot commented Sep 3, 2025

View your CI Pipeline Execution ↗ for commit 0c9fa37

Command Status Duration Result
nx run-many --target=build --parallel=3 ✅ Succeeded 36s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-03 16:39:31 UTC

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 919d5b8 with previous commit b05dd6e.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 40 🔴 35 ↓ −5
Code coverage 🟡 90 🟡 90 ↑ +0.1
Documentation 🔴 24 🔴 24 ↓ −0.1
Security 🟡 64 🟡 64
Updates 🟡 85 🟡 85
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Type Safety 🟢 100 🟢 100
Bug prevention 🟢 100 🟢 100
Miscellaneous 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👍 1 group improved, 👎 2 groups regressed, 👍 4 audits improved, 👎 6 audits regressed, 15 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 40 🔴 35 ↓ −5
Code coverage Code coverage metrics 🟡 90 🟡 90 ↑ +0.1
JSDoc coverage Documentation coverage 🔴 24 🔴 24 ↓ −0.1

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Speed Index 🟨 5.7 s 🟥 6.6 s ↑ +16.1 %
Lighthouse Total Blocking Time 🟥 1,330 ms 🟥 2,370 ms ↑ +78.2 %
Lighthouse Max Potential First Input Delay 🟥 550 ms 🟥 790 ms ↑ +45.2 %
Lighthouse Time to Interactive 🟥 15.9 s 🟥 16.5 s ↑ +4 %
Code coverage Line coverage 🟨 86.2 % 🟨 86.2 % ↑ +0.1 %
Code coverage Branch coverage 🟨 85.5 % 🟨 85.5 % ↑ +0.1 %
JSDoc coverage Functions coverage 🟥 518 undocumented functions 🟥 520 undocumented functions ↑ +0.4 %
JSDoc coverage Types coverage 🟥 236 undocumented types 🟥 239 undocumented types ↑ +1.3 %
JSDoc coverage Variables coverage 🟥 289 undocumented variables 🟥 292 undocumented variables ↑ +1 %
Code coverage Function coverage 🟩 92.2 % 🟩 92.2 % ↑ +0.1 %
Lighthouse Avoids enormous network payloads 🟨 Total size was 2,673 KiB 🟨 Total size was 2,672 KiB ↓ −0.1 %
Lighthouse Minimizes main-thread work 🟥 7.8 s 🟥 9.1 s ↑ +16.9 %
Lighthouse JavaScript execution time 🟥 3.2 s 🟥 4.4 s ↑ +37.3 %
Lighthouse Largest Contentful Paint 🟥 10.7 s 🟥 11.5 s ↑ +7.5 %
Lighthouse Uses efficient cache policy on static assets 🟨 30 resources found 🟨 30 resources found ↓ −0.1 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +4 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 85 KiB 🟥 Potential savings of 99 KiB ↑ +56.7 %
Lighthouse Initial server response time was short 🟩 Root document took 540 ms 🟩 Root document took 440 ms ↓ −18.4 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 113 KiB 🟥 Potential savings of 113 KiB ↑ +3.3 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 608 KiB 🟥 Potential savings of 579 KiB ↑ +2.2 %
Lighthouse First Contentful Paint 🟨 3.0 s 🟨 3.0 s ↓ −0.6 %
Lighthouse Network Round Trip Times 🟩 10 ms 🟩 10 ms ↑ +74.1 %
Lighthouse Server Backend Latencies 🟩 1,450 ms 🟩 1,460 ms ↑ +0.4 %
JS Packages Outdated NPM prod dependencies. 🟨 14 outdated package versions (3 major, 6 minor, 5 patch) 🟨 15 outdated package versions (3 major, 7 minor, 5 patch) ↑ +7.1 %
Lighthouse Cumulative Layout Shift 🟩 0.001 🟩 0 ↓ −100 %

585 other audits are unchanged.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 3, 2025

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1103

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1103

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1103

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1103

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1103

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1103

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1103

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1103

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1103

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1103

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1103

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1103

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1103

@code-pushup/models-transformers

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models-transformers@1103

commit: 0c9fa37

Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small improvement

@matejchalk matejchalk merged commit fd79217 into main Sep 3, 2025
28 of 29 checks passed
@matejchalk matejchalk deleted the fix-runner-persist-args branch September 3, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants