-
Notifications
You must be signed in to change notification settings - Fork 16
fix(plugin-lighthouse): prevent cleanup permissions error on windows #1124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit ebabf97
☁️ Nx Cloud last updated this comment at |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit ee07af5 with previous commit b7ce5c6. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 3 groups improved, 👍 4 audits improved, 👎 2 audits regressed, 15 audits changed without impacting score🗃️ Groups
18 other groups are unchanged. 🛡️ Audits
589 other audits are unchanged. |
16fb9b4 to
c511865
Compare
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/coverage-plugin
@code-pushup/nx-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
@code-pushup/models-transformers
commit: |
b113192 to
5216eb5
Compare
5216eb5 to
ebabf97
Compare
vmasek
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1122
The permissions error seems to be a cleanup bug in
lighthouse/chrome-launcher(see GoogleChrome/chrome-launcher#355). Overriding the default system temporary directory path on Windows to a local path fixes the tests.From Node.js
os.tmpdir()docs:I suspect GitHub's recent
windows-latestimage migration might be the reason the jobs started failing for us recently.