-
Notifications
You must be signed in to change notification settings - Fork 16
build(models-transformers): cache ts-patch install #1133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 4628541
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/create-cli
@code-pushup/core
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
@code-pushup/models-transformers
commit: |
Contributor
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit c40a4cb with previous commit 7ed8e49. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👎 1 group regressed, 👍 3 audits improved, 👎 1 audit regressed, 17 audits changed without impacting score🗃️ Groups
20 other groups are unchanged. 🛡️ Audits
589 other audits are unchanged. |
vmasek
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
models-transformers:pre-buildtarget cacheable.Because of the
models:build➡️models-transformers:build➡️models-transformers:pre-builddependencies, any tasks that depend on^buildare likely to run thispre-buildtarget, so it's very frequent. It's inconvenient to have an uncachable task at the root of our task graph.The
pre-buildtarget runsts-patch install, which is a no-op if it's been run before. So I took advantage of thets-patch checkcommand that prints installed versions. If the output is the same as what's cached, thets-patch installcommand is skipped.