Skip to content

Conversation

@matejchalk
Copy link
Collaborator

@matejchalk matejchalk commented Oct 31, 2025

This PR makes the models-transformers:pre-build target cacheable.

Because of the models:build ➡️ models-transformers:build ➡️ models-transformers:pre-build dependencies, any tasks that depend on ^build are likely to run this pre-build target, so it's very frequent. It's inconvenient to have an uncachable task at the root of our task graph.

The pre-build target runs ts-patch install, which is a no-op if it's been run before. So I took advantage of the ts-patch check command that prints installed versions. If the output is the same as what's cached, the ts-patch install command is skipped.

@nx-cloud
Copy link

nx-cloud bot commented Oct 31, 2025

View your CI Pipeline Execution ↗ for commit 4628541

Command Status Duration Result
nx code-pushup --nx-bail -- compare ✅ Succeeded 55s View ↗
nx code-pushup --nx-bail -- ✅ Succeeded 1m 6s View ↗
nx code-pushup --nx-bail -- print-config --outp... ✅ Succeeded 3m 44s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-31 09:31:23 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 31, 2025

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1133

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1133

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1133

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1133

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1133

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1133

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1133

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1133

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1133

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1133

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1133

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1133

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1133

@code-pushup/models-transformers

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models-transformers@1133

commit: 4628541

@github-actions
Copy link
Contributor

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit c40a4cb with previous commit 7ed8e49.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 33 🔴 33 ↓ −0.1
Code coverage 🟢 90 🟢 90
Security 🟡 56 🟡 56
Updates 🟡 73 🟡 73
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Type Safety 🟢 100 🟢 100
Bug prevention 🟢 100 🟢 100
Miscellaneous 🟢 100 🟢 100
Code style 🟢 100 🟢 100
Documentation 🔴 36 🔴 36
👎 1 group regressed, 👍 3 audits improved, 👎 1 audit regressed, 17 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 33 🔴 33 ↓ −0.1

20 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Initial server response time was short 🟥 Root document took 800 ms 🟩 Root document took 590 ms ↓ −25.6 %
Lighthouse First Contentful Paint 🟥 3.2 s 🟥 3.3 s ↑ +4.7 %
Lighthouse Speed Index 🟥 7.4 s 🟥 7.1 s ↓ −4.7 %
Lighthouse Time to Interactive 🟥 14.9 s 🟥 13.8 s ↓ −7.2 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,105 KiB 🟩 Total size was 2,037 KiB ↓ −3.2 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −7.2 %
Lighthouse Server Backend Latencies 🟩 1,940 ms 🟩 1,070 ms ↓ −44.6 %
Lighthouse Minimizes main-thread work 🟥 14.0 s 🟥 14.8 s ↑ +6.1 %
Lighthouse Largest Contentful Paint 🟥 12.9 s 🟥 12.2 s ↓ −5.4 %
Lighthouse JavaScript execution time 🟥 5.6 s 🟥 5.9 s ↑ +6.7 %
Lighthouse Total Blocking Time 🟥 2,530 ms 🟥 2,660 ms ↑ +4.9 %
Lighthouse Avoids an excessive DOM size 🟥 2,371 elements 🟥 2,255 elements ↓ −4.9 %
Lighthouse Max Potential First Input Delay 🟥 1,460 ms 🟥 1,560 ms ↑ +6.7 %
Lighthouse Uses efficient cache policy on static assets 🟨 30 resources found 🟨 30 resources found ↑ +0.1 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 185 KiB 🟥 Potential savings of 180 KiB ↑ +8.4 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 104 KiB 🟥 Potential savings of 97 KiB ↓ −10 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 92 KiB 🟥 Potential savings of 72 KiB ↓ −9.1 %
Lighthouse Network Round Trip Times 🟩 50 ms 🟩 70 ms ↑ +46.9 %
JS Packages Outdated NPM prod dependencies. 🟨 16 outdated package versions (6 major, 6 minor, 4 patch) 🟨 17 outdated package versions (6 major, 7 minor, 4 patch) ↑ +6.3 %
Code coverage Branch coverage 🟨 86 % 🟨 86 % ↑ +0.1 %
Lighthouse Cumulative Layout Shift 🟩 0.002 🟩 0 ↓ −100 %

589 other audits are unchanged.

@matejchalk matejchalk marked this pull request as ready for review October 31, 2025 09:33
@matejchalk matejchalk merged commit c4b025c into main Oct 31, 2025
25 checks passed
@matejchalk matejchalk deleted the cacheable-model-transformers-build branch October 31, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants