Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/create-cli/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,13 @@ Each plugin exposes its own configuration keys that can be passed as CLI argumen
| **`--lighthouse.urls`** | `string \| string[]` | `http://localhost:4200` | Target URL(s) (comma-separated) |
| **`--lighthouse.categories`** | `('performance'` \| `'a11y'` \| `'best-practices'` \| `'seo')[]` | all | Lighthouse categories |

#### JSDocs

| Option | Type | Default | Description |
| ------------------------- | -------------------- | -------------------------------------------- | -------------------------------------- |
| **`--jsdocs.patterns`** | `string \| string[]` | `src/**/*.ts, src/**/*.js, !**/node_modules` | Source file patterns (comma-separated) |
| **`--jsdocs.categories`** | `boolean` | `true` | Add JSDocs categories |

#### Axe

| Option | Type | Default | Description |
Expand Down
3 changes: 2 additions & 1 deletion packages/create-cli/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { axeSetupBinding } from '@code-pushup/axe-plugin';
import { coverageSetupBinding } from '@code-pushup/coverage-plugin';
import { eslintSetupBinding } from '@code-pushup/eslint-plugin';
import { jsPackagesSetupBinding } from '@code-pushup/js-packages-plugin';
import { jsDocsSetupBinding } from '@code-pushup/jsdocs-plugin';
import { lighthouseSetupBinding } from '@code-pushup/lighthouse-plugin';
import { typescriptSetupBinding } from '@code-pushup/typescript-plugin';
import { parsePluginSlugs, validatePluginSlugs } from './lib/setup/plugins.js';
Expand All @@ -16,14 +17,14 @@ import {
} from './lib/setup/types.js';
import { runSetupWizard } from './lib/setup/wizard.js';

// TODO: create, import and pass remaining plugin bindings (jsdocs)
const bindings: PluginSetupBinding[] = [
eslintSetupBinding,
coverageSetupBinding,
jsPackagesSetupBinding,
typescriptSetupBinding,
lighthouseSetupBinding,
axeSetupBinding,
jsDocsSetupBinding,
];

const argv = await yargs(hideBin(process.argv))
Expand Down
1 change: 1 addition & 0 deletions packages/plugin-jsdocs/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { jsDocsPlugin } from './lib/jsdocs-plugin.js';

export default jsDocsPlugin;
export { jsDocsSetupBinding } from './lib/binding.js';
export type { JsDocsPluginConfig } from './lib/config.js';
93 changes: 93 additions & 0 deletions packages/plugin-jsdocs/src/lib/binding.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,93 @@
import { createRequire } from 'node:module';
import type {
CategoryConfig,
PluginAnswer,
PluginSetupBinding,
} from '@code-pushup/models';
import {
answerBoolean,
answerNonEmptyArray,
singleQuote,
} from '@code-pushup/utils';
import { PLUGIN_SLUG, PLUGIN_TITLE } from './constants.js';

const { name: PACKAGE_NAME } = createRequire(import.meta.url)(
'../../package.json',
) as typeof import('../../package.json');

const DEFAULT_PATTERNS: [string, ...string[]] = [
'src/**/*.ts',
'src/**/*.js',
'!**/node_modules',
];

const CATEGORY: CategoryConfig = {
slug: 'docs',
title: 'Documentation',
description: 'Measures how much of your code is **documented**.',
refs: [
{
type: 'group',
plugin: PLUGIN_SLUG,
slug: 'documentation-coverage',
weight: 1,
},
],
};

type JsDocsOptions = {
patterns: [string, ...string[]];
categories: boolean;
};

export const jsDocsSetupBinding = {
slug: PLUGIN_SLUG,
title: PLUGIN_TITLE,
packageName: PACKAGE_NAME,
prompts: async () => [
{
key: 'jsdocs.patterns',
message: 'Source file patterns (comma-separated)',
type: 'input',
default: DEFAULT_PATTERNS.join(', '),
},
{
key: 'jsdocs.categories',
message: 'Add JSDocs categories?',
type: 'confirm',
default: true,
},
],
generateConfig: (answers: Record<string, PluginAnswer>) => {
const options = parseAnswers(answers);
return {
imports: [
{ moduleSpecifier: PACKAGE_NAME, defaultImport: 'jsDocsPlugin' },
],
pluginInit: formatPluginInit(options.patterns),
...(options.categories ? { categories: [CATEGORY] } : {}),
};
},
} satisfies PluginSetupBinding;

function parseAnswers(answers: Record<string, PluginAnswer>): JsDocsOptions {
return {
patterns: answerNonEmptyArray(
answers,
'jsdocs.patterns',
DEFAULT_PATTERNS[0],
),
categories: answerBoolean(answers, 'jsdocs.categories'),
};
}

function formatPluginInit([first, ...rest]: [string, ...string[]]): string[] {
if (rest.length === 0) {
return [`jsDocsPlugin(${singleQuote(first)}),`];
}
return [
'jsDocsPlugin([',
...[first, ...rest].map(p => ` ${singleQuote(p)},`),
']),',
];
}
83 changes: 83 additions & 0 deletions packages/plugin-jsdocs/src/lib/binding.unit.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,83 @@
import type { PluginAnswer } from '@code-pushup/models';
import { jsDocsSetupBinding as binding } from './binding.js';

const defaultAnswers: Record<string, PluginAnswer> = {
'jsdocs.patterns': 'src/**/*.ts, src/**/*.js, !**/node_modules',
'jsdocs.categories': true,
};

const noCategoryAnswers: Record<string, PluginAnswer> = {
...defaultAnswers,
'jsdocs.categories': false,
};

describe('jsDocsSetupBinding', () => {
describe('prompts', () => {
it('should default to common TypeScript and JavaScript source patterns', async () => {
await expect(binding.prompts!()).resolves.toIncludeAllPartialMembers([
{
key: 'jsdocs.patterns',
type: 'input',
default: 'src/**/*.ts, src/**/*.js, !**/node_modules',
},
]);
});

it('should offer to add categories by default', async () => {
await expect(binding.prompts!()).resolves.toIncludeAllPartialMembers([
{ key: 'jsdocs.categories', type: 'confirm', default: true },
]);
});
});

describe('generateConfig', () => {
it('should import from @code-pushup/jsdocs-plugin', () => {
const { imports } = binding.generateConfig(defaultAnswers);
expect(imports).toStrictEqual([
expect.objectContaining({
defaultImport: 'jsDocsPlugin',
}),
]);
});

it('should pass multiple patterns as array to plugin call', () => {
const { pluginInit } = binding.generateConfig(defaultAnswers);
expect(pluginInit).toStrictEqual([
'jsDocsPlugin([',
" 'src/**/*.ts',",
" 'src/**/*.js',",
" '!**/node_modules',",
']),',
]);
});

it('should pass single pattern as string to plugin call', () => {
const { pluginInit } = binding.generateConfig({
...defaultAnswers,
'jsdocs.patterns': 'src/**/*.ts',
});
expect(pluginInit).toStrictEqual(["jsDocsPlugin('src/**/*.ts'),"]);
});

it('should generate Documentation category from documentation-coverage group', () => {
const { categories } = binding.generateConfig(defaultAnswers);
expect(categories).toStrictEqual([
expect.objectContaining({
slug: 'docs',
title: 'Documentation',
refs: [
expect.objectContaining({
plugin: 'jsdocs',
slug: 'documentation-coverage',
}),
],
}),
]);
});

it('should omit categories when declined', () => {
const { categories } = binding.generateConfig(noCategoryAnswers);
expect(categories).toBeUndefined();
});
});
});
Loading