Skip to content

fix(ci): slugify project name in configPatterns#1284

Merged
matejchalk merged 1 commit into
mainfrom
handle-scoped-package-names
May 19, 2026
Merged

fix(ci): slugify project name in configPatterns#1284
matejchalk merged 1 commit into
mainfrom
handle-scoped-package-names

Conversation

@matejchalk
Copy link
Copy Markdown
Collaborator

This change is necessary to support configPatterns in workspaces that use scoped npm package names as the project name (typically defined in package.json). Such names (e.g., @my-org/my-pkg) are not valid for upload.project, and need to be slugified (e.g., my-org-my-pkg) dynamically, since the user only configures the {projectName} pattern.

@github-actions github-actions Bot added 📖 Project documentation improvements or additions to the project documentation 🧩 ci labels May 19, 2026
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented May 19, 2026

View your CI Pipeline Execution ↗ for commit a54faf6

Command Status Duration Result
nx run ci:code-pushup -- merge-diffs --files=/h... ✅ Succeeded 6s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 1m 36s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 14m 22s View ↗
nx run-many -t unit-test,int-test ✅ Succeeded 2m 2s View ↗

☁️ Nx Cloud last updated this comment at 2026-05-19 14:46:30 UTC

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 19, 2026

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1284

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1284

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1284

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1284

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1284

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1284

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1284

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1284

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1284

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1284

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1284

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1284

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1284

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1284

commit: a54faf6

@github-actions
Copy link
Copy Markdown
Contributor

Code PushUp

😟 Code PushUp report has regressed – compared current commit c3daf2f with previous commit 47eb97a.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 38 🔴 34 ↓ −4.2
Best Practices 🟢 100 🟢 97 ↓ −3.4
Updates 🟡 73 🟡 72 ↓ −0.4
Bug prevention 🟡 75 🟡 75 ↓ −0.1
Axe Accessibility 🟡 88 🟡 88 ↓ −0.1
Code style 🟢 100 🟢 100
Code coverage 🟢 92 🟢 92
Security 🔴 0 🔴 0
Type Safety 🟡 67 🟡 67
Miscellaneous 🟡 67 🟡 67
Documentation 🟡 51 🟡 51
Accessibility 🟢 92 🟢 92
SEO 🟢 92 🟢 92
👎 3 groups regressed, 👎 6 audits regressed, 22 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 38 🔴 34 ↓ −4.2
Lighthouse Best Practices 🟢 100 🟢 97 ↓ −3.4
JS packages npm outdated dependencies 🟡 73 🟡 72 ↓ −0.4

31 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse No browser errors logged to the console 🟩 passed 🟥 failed ↓ −100 %
Lighthouse Speed Index 🟥 6.1 s 🟥 6.9 s ↑ +13.3 %
Lighthouse Total Blocking Time 🟥 1,550 ms 🟥 2,830 ms ↑ +82.2 %
Lighthouse Max Potential First Input Delay 🟥 520 ms 🟥 780 ms ↑ +52.2 %
JS packages Outdated npm dev dependencies. 🟨 62 outdated package versions (34 major, 22 minor, 6 patch) 🟨 65 outdated package versions (36 major, 22 minor, 7 patch) ↑ +4.8 %
Lighthouse Time to Interactive 🟥 13.7 s 🟥 14.7 s ↑ +7.2 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,450 KiB 🟩 Total size was 2,475 KiB ↑ +1 %
Lighthouse Minimizes main-thread work 🟥 9.6 s 🟥 11.4 s ↑ +18.3 %
Lighthouse JavaScript execution time 🟥 2.7 s 🟥 4.3 s ↑ +57 %
Lighthouse Uses efficient cache policy on static assets 🟨 31 resources found 🟨 31 resources found ↑ +0.2 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +7.2 %
Lighthouse Largest Contentful Paint 🟥 9.7 s 🟥 10.0 s ↑ +3.2 %
Lighthouse Initial server response time was short 🟥 Root document took 680 ms 🟥 Root document took 920 ms ↑ +35.8 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 302 KiB 🟥 Potential savings of 379 KiB ↓ −15.3 %
Lighthouse Server Backend Latencies 🟩 1,420 ms 🟩 1,250 ms ↓ −11.8 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 106 KiB 🟥 Potential savings of 101 KiB ↑ +45.2 %
Lighthouse Network Round Trip Times 🟩 10 ms 🟩 70 ms ↑ +400.2 %
Lighthouse First Contentful Paint 🟥 3.2 s 🟥 3.2 s ↑ +0.7 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 110 KiB 🟥 Potential savings of 128 KiB ↓ −3.2 %
Axe IDs used in ARIA and labels must be unique 🟩 27 elements 🟩 42 elements ↑ +55.6 %
JS packages Vulnerabilities for npm prod dependencies. 🟥 21 vulnerabilities (2 critical, 8 high, 5 moderate, 6 low) 🟥 25 vulnerabilities (2 critical, 9 high, 8 moderate, 6 low) ↑ +19 %
JS packages Vulnerabilities for npm dev dependencies. 🟥 75 vulnerabilities (4 critical, 43 high, 22 moderate, 6 low) 🟥 78 vulnerabilities (4 critical, 46 high, 22 moderate, 6 low) ↑ +4 %
Axe Inline text spacing must be adjustable with custom stylesheets 🟩 50 elements 🟩 53 elements ↑ +6 %
Lighthouse Avoids an excessive DOM size 🟥 2,347 elements 🟥 2,345 elements ↓ −0.1 %
Axe Deprecated ARIA roles must not be used 🟩 6 elements 🟩 5 elements ↓ −16.7 %
Axe Required ARIA attributes must be provided 🟩 6 elements 🟩 5 elements ↓ −16.7 %
Axe ARIA roles used must conform to valid values 🟩 6 elements 🟩 5 elements ↓ −16.7 %
Code coverage Line coverage 🟩 92.3 % 🟩 92.3 % ↑ +0.1 %

650 other audits are unchanged.

@github-actions
Copy link
Copy Markdown
Contributor

Code PushUp

🥳 Code PushUp report has improved – compared current commit c3daf2f with previous commit 47eb97a.

💼 Project plugin-coverage

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Documentation 🟡 68 🟡 68 ↑ +0.1

5 other categories are unchanged.

👍 1 group improved

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JSDocs coverage Documentation coverage 🟡 68 🟡 68 ↑ +0.1

14 other groups are unchanged.

🛡️ Audits

All of 444 audits are unchanged.

💼 Project ci

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

All of 6 categories are unchanged.

1 audit changed without impacting score

🗃️ Groups

All of 15 groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Line coverage 🟩 93.6 % 🟩 93.6 % ↑ +0.1 %

444 other audits are unchanged.


12 other projects are unchanged.

@matejchalk matejchalk requested review from hanna-skryl and vmasek May 19, 2026 14:52
@matejchalk matejchalk merged commit 5947011 into main May 19, 2026
25 checks passed
@matejchalk matejchalk deleted the handle-scoped-package-names branch May 19, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧩 ci 📖 Project documentation improvements or additions to the project documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants