fix(ci): slugify project name in configPatterns#1284
Conversation
|
View your CI Pipeline Execution ↗ for commit a54faf6
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/nx-plugin
@code-pushup/axe-plugin
@code-pushup/models
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
commit: |
Code PushUp😟 Code PushUp report has regressed – compared current commit c3daf2f with previous commit 47eb97a. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👎 3 groups regressed, 👎 6 audits regressed, 22 audits changed without impacting score🗃️ Groups
31 other groups are unchanged. 🛡️ Audits
650 other audits are unchanged. |
Code PushUp🥳 Code PushUp report has improved – compared current commit c3daf2f with previous commit 47eb97a. 💼 Project
|
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Documentation | 🟡 68 | 🟡 68 |
5 other categories are unchanged.
👍 1 group improved
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| JSDocs coverage | Documentation coverage | 🟡 68 | 🟡 68 |
14 other groups are unchanged.
🛡️ Audits
All of 444 audits are unchanged.
💼 Project ci
🤨 Code PushUp report has both improvements and regressions.
🕵️ See full comparison in Code PushUp portal 🔍
All of 6 categories are unchanged.
1 audit changed without impacting score
🗃️ Groups
All of 15 groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Line coverage | 🟩 93.6 % | 🟩 93.6 % |
444 other audits are unchanged.
12 other projects are unchanged.
This change is necessary to support
configPatternsin workspaces that use scoped npm package names as the project name (typically defined inpackage.json). Such names (e.g.,@my-org/my-pkg) are not valid forupload.project, and need to be slugified (e.g.,my-org-my-pkg) dynamically, since the user only configures the{projectName}pattern.