feat(plugin-lighthouse): add lighthouse plugin #593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/plugin-lighthouse/src/lib/utils.unit.test.ts
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Katka Pilátová <katerina.pilatova@flowup.cz>
matejchalk
reviewed
Apr 10, 2024
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Tlacenka
reviewed
Apr 10, 2024
Co-authored-by: Katka Pilátová <katerina.pilatova@flowup.cz>
matejchalk
previously approved these changes
Apr 10, 2024
matejchalk
approved these changes
Apr 10, 2024
Tlacenka
reviewed
Apr 10, 2024
Tlacenka
approved these changes
Apr 10, 2024
Collaborator
Tlacenka
left a comment
Tlacenka
left a comment
There was a problem hiding this comment.
The last commented changes can be done in a follow-up PR.
Collaborator
Author
|
The following comments will get addressed in a followup PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes all remaining snippets and docs to release the Lighthouse plugin.
In the process of comparing the code with the existing plugins I renamed and moved a couple of files. To get a better overview I grouped the changes as seen below.
Polish from #549:
Moving existing code:
Removed code:
getLighthouseCliArgumentsfunction (better types and direct derivation from lighthouse made it obsolete)New code in tests:
getConfigwith errorgetConfigNew code in logic:
CategoryRefs@types/debugfor better typingflagtypesNote
The e2e tests of compare are hard to change as they require a clean history to run. This could get discussed on how to fix it.
Followup changes:
skipAudits#598closes #90