Skip to content

Conversation

@BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Apr 10, 2024

Addressing: #593 (comment)

@BioPhoton BioPhoton marked this pull request as ready for review April 10, 2024 21:53
@BioPhoton BioPhoton requested a review from Tlacenka April 10, 2024 21:53
@github-actions
Copy link
Contributor

github-actions bot commented Apr 10, 2024

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit be538e1 with source commit ac5a0e2.

🏷️ Categories

🏷️ Category ⭐ Current score ⭐ Previous score 🔄 Score change
Performance 🟡 71 🟡 83 ↓ −12.2
Updates 🟡 68 🟡 68 ↑ +0.6
Code coverage 🟡 67 🟡 66 ↑ +0.4
Accessibility 🟢 100 🟢 100
Best Practices 🟢 100 🟢 100
SEO 🟡 86 🟡 86
PWA 🔴 38 🔴 38
Bug prevention 🟢 100 🟢 100
Code style 🟢 99 🟢 99
Security 🟡 80 🟡 80
Custom checks 🟡 67 🟡 67

🗃️ Groups

👍 2 groups improved, 👎 1 group regressed
🔌 Plugin 🗃️ Group ⭐ Current score ⭐ Previous score 🔄 Score change
Lighthouse Performance 🟡 71 🟡 83 ↓ −12.2
JS Packages NPM outdated dependencies 🟡 68 🟡 68 ↑ +0.6
Code coverage Code coverage metrics 🟡 67 🟡 66 ↑ +0.4

18 other groups are unchanged.

🛡️ Audits

👍 4 audits improved, 👎 7 audits regressed, 9 audits changed without impacting score
🔌 Plugin 🛡️ Audit 📏 Current value 📏 Previous value 🔄 Value change
Lighthouse Largest Contentful Paint 🟨 3.6 s 🟨 2.7 s ↑ +33 %
Lighthouse Max Potential First Input Delay 🟥 630 ms 🟥 350 ms ↑ +77 %
Lighthouse Total Blocking Time 🟥 710 ms 🟨 510 ms ↑ +39 %
Lighthouse First Contentful Paint 🟨 2.0 s 🟩 1.3 s ↑ +53 %
Lighthouse First Meaningful Paint 🟩 2.0 s 🟩 1.3 s ↑ +53 %
Lighthouse Time to Interactive 🟩 3.8 s 🟩 3.2 s ↑ +19 %
Lighthouse Speed Index 🟩 2.7 s 🟩 1.6 s ↑ +74 %
JS Packages Outdated NPM dev dependencies. 🟥 41 outdated package versions (24 major, 12 minor, 5 patch) 🟥 39 outdated package versions (24 major, 12 minor, 3 patch) ↑ +5 %
Code coverage Function coverage 🟨 59 % 🟨 59 %  +0 %
Code coverage Branch coverage 🟨 82 % 🟨 82 %  +0 %
Code coverage Line coverage 🟨 65 % 🟨 64 % ↑ +2 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 467 KiB 🟩 Total size was 449 KiB ↑ +4 %
Lighthouse Minimizes main-thread work 🟥 4.2 s 🟥 3.2 s ↑ +31 %
Lighthouse Metrics 🟩 3762 🟩 3166 ↑ +19 %
Lighthouse JavaScript execution time 🟩 1.2 s 🟩 0.9 s ↑ +33 %
Lighthouse Properly size images 🟥 Potential savings of 327 KiB 🟥 Potential savings of 327 KiB ↑ +5 %
Lighthouse Initial server response time was short 🟩 Root document took 10 ms 🟩 Root document took 0 ms ↑ +300 %
Lighthouse Server Backend Latencies 🟩 10 ms 🟩 10 ms ↑ +100 %
Lighthouse Network Round Trip Times 🟩 10 ms 🟩 0 ms ↑ +500 %
Lighthouse Uses efficient cache policy on static assets 🟨 14 resources found 🟨 14 resources found ↑ +0 %

503 other audits are unchanged.

@BioPhoton BioPhoton requested a review from Tlacenka April 14, 2024 12:43
Copy link
Collaborator

@Tlacenka Tlacenka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

@BioPhoton BioPhoton merged commit 0691ea8 into main Apr 14, 2024
@BioPhoton BioPhoton deleted the add-lighthouse-tests branch April 14, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants