Skip to content

Conversation

@vmasek
Copy link
Collaborator

@vmasek vmasek commented Feb 14, 2025

CLI hangs in certain situations, we do open many sub processes and some of them maybe don't exit properly.
For immediate fix we need to explicitly exist with successful code.

closes #468

@github-actions
Copy link
Contributor

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit c2e5eaf with source commit 6c0097f.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 52 🔴 49 ↓ −3
Code coverage 🟢 91 🟢 91 ↓ −0.1
Security 🟡 79 🟡 79
Updates 🟡 77 🟡 77
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
Documentation 🔴 23 🔴 23
👎 2 groups regressed, 👍 1 audit improved, 👎 5 audits regressed, 11 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 52 🔴 49 ↓ −3
Code coverage Code coverage metrics 🟢 91 🟢 91 ↓ −0.1

16 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Speed Index 🟨 4.9 s 🟥 6.8 s ↑ +38.5 %
Lighthouse Largest Contentful Paint 🟨 3.7 s 🟨 3.6 s ↓ −3.2 %
Lighthouse Total Blocking Time 🟥 3,010 ms 🟥 5,180 ms ↑ +72.3 %
Lighthouse Time to Interactive 🟥 13.5 s 🟥 14.2 s ↑ +4.8 %
Lighthouse First Contentful Paint 🟨 2.8 s 🟨 2.8 s ↑ +1.1 %
Code coverage Line coverage 🟨 89.7 % 🟨 89.7 % ↓ −0.1 %
Lighthouse Minimizes main-thread work 🟥 12.5 s 🟥 17.1 s ↑ +37 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,820 KiB 🟩 Total size was 1,825 KiB ↑ +0.2 %
Lighthouse JavaScript execution time 🟥 6.2 s 🟥 7.2 s ↑ +16.2 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +4.8 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 1,070 ms 🟥 Potential savings of 590 ms ↓ −45.2 %
Lighthouse Max Potential First Input Delay 🟥 1,910 ms 🟥 2,220 ms ↑ +16.1 %
Lighthouse Initial server response time was short 🟩 Root document took 400 ms 🟩 Root document took 560 ms ↑ +37.7 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 67 KiB 🟥 Potential savings of 67 KiB ↓ −33.3 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↓ −0.1 %
Lighthouse Server Backend Latencies 🟩 120 ms 🟩 210 ms ↑ +74.2 %
Lighthouse Network Round Trip Times 🟩 30 ms 🟩 40 ms ↑ +46 %

579 other audits are unchanged.

@vmasek
Copy link
Collaborator Author

vmasek commented Feb 14, 2025

@matejchalk I'd merge this one and have a look on the E2E separately, it looks like some output expects version in the snapshot

@matejchalk
Copy link
Collaborator

I'd merge this one and have a look on the E2E separately, it looks like some output expects version in the snapshot

Yes, it looks like that test is flaky. It shouldn't rely in our current version.

@vmasek vmasek merged commit 2cb815b into main Feb 14, 2025
14 of 17 checks passed
@vmasek vmasek deleted the explicit-process-exit branch February 14, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Process is not terminating on its own

3 participants