Add CVO override for cluster-node-tuning#240
Merged
Merged
Conversation
cfergeau
approved these changes
Sep 24, 2020
Contributor
There was a problem hiding this comment.
"and it need tune profile to work" -> "and it needs tune profile to work"
I don't understand exactly what you mean with this though
You could also stop the sentence right after this:
it need tune profile to work and when it updated node needs reboot,
which is not possible for CRC so better to remove the resources
for tihs operator.
becomes
it needs tune profile to work. After it is updated, the node needs reboot,
which is not possible for CRC so better to remove the resources
for tihs operator.
(also tihs -> this)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau, praveenkumar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Node tuning operator is used to tune the node as per workload. it needs tune profile to work. After it is updated, the node needs reboot, which is not possible for CRC so better to remove the resources for this operator.
praveenkumar
force-pushed
the
remove_node_tuning
branch
from
b83605f to
a02e996
Compare
|
New changes are detected. LGTM label has been removed. |
Member
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node tuning operator is used to tune the node as per workload and
it need tune profile to work and when it updated node needs reboot,
which is not possible for CRC so better to remove the resources
for tihs operator.