Migration towards nnbd. #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move trees and tests to nnbd.
happy-san
commented
Dec 20, 2020
| /// | ||
| /// In [AvlTree] it is the primary focus to actively balance out all | ||
| /// imbalanced [node]s following addition or deletion. | ||
| int balanceFactor = 0; |
Collaborator
Author
There was a problem hiding this comment.
How about using a Map here? Combines the good of both enum and current definition
'rightHeavy' -> -1
'balanced' -> 0
'leftHeavy' -> 1
Collaborator
Author
There was a problem hiding this comment.
Actually, I like this implementation
enum BalanceState { rightHeavy, balanced, leftHeavy }
class Node {
BalanceState balanceState = BalanceState.balanced;
int get balanceFactor {
switch (balanceState) {
case BalanceState.rightHeavy:
return -1;
case BalanceState.balanced:
return 0;
case BalanceState.leftHeavy:
return 1;
}
}
}
void main() {
var node = Node();
print(node.balanceState);
print(node.balanceFactor);
}This prints
BalanceState.balanced
0
Collaborator
Author
There was a problem hiding this comment.
It just occured to me, if a node is leftHeavy, it's balance factor can be any natural number. Similarly rightHeavy node's balance factor can be any negative integer. So by definition, it cannot be hardcoded, like I did.
lib/trees/avl_tree.dart
Outdated
Comment on lines
458
to
471
| // [node] was balanced before deletion. (Both left and right subtree had | ||
| // the same height.) | ||
| // N | ||
| // / \ | ||
| // ** ** | ||
| case 0: | ||
| // node is right heavy now. | ||
| // [node] is right heavy now. | ||
| // N | ||
| // / \ | ||
| // * ** | ||
| node.balanceFactor = -1; | ||
| _isShorter = false; | ||
| break; | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
@code-shoily Do you think the added comment helps or it's just cluttering?
code-shoily
approved these changes
Dec 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on AvlTree, I've migrated it to nnbd but I'm updating comments.
#35