-
Notifications
You must be signed in to change notification settings - Fork 30
Step4 #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Step4 #131
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| package codesquad.domain; | ||
|
|
||
| public enum ContentType { | ||
| Issue; | ||
| ISSUE | ||
| } |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| package codesquad.domain; | ||
|
|
||
| import javax.persistence.*; | ||
| import java.time.LocalDateTime; | ||
|
|
||
| @Entity | ||
| public class DeleteHistory { | ||
|
|
||
| @Id | ||
| @GeneratedValue | ||
| private Long id; | ||
|
|
||
| @Enumerated(EnumType.STRING) | ||
| private ContentType contentType; | ||
|
|
||
| private Long contentId; | ||
|
|
||
| @ManyToOne | ||
| @JoinColumn(foreignKey = @ForeignKey(name = "fk_deletehistory_to_user")) | ||
| private User deletedByUser; | ||
|
|
||
| private LocalDateTime createDate = LocalDateTime.now(); | ||
|
|
||
|
|
||
| public DeleteHistory() { | ||
| } | ||
|
|
||
| public DeleteHistory(ContentType contentType, Long contentId, User deletedByUser, LocalDateTime createDate) { | ||
| this.contentType = contentType; | ||
| this.contentId = contentId; | ||
| this.deletedByUser = deletedByUser; | ||
| this.createDate = createDate; | ||
| } | ||
|
|
||
| public DeleteHistory(ContentType contentType, Long contentId, User deletedByUser) { | ||
| this.contentType = contentType; | ||
| this.contentId = contentId; | ||
| this.deletedByUser = deletedByUser; | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return "DeleteHistory{" + | ||
| "id=" + id + | ||
| ", contentType=" + contentType + | ||
| ", contentId=" + contentId + | ||
| ", deletedByUser=" + deletedByUser + | ||
| ", createDate=" + createDate + | ||
| '}'; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| package codesquad.domain; | ||
|
|
||
| import support.domain.AbstractEntity; | ||
|
|
||
| import javax.persistence.*; | ||
| import java.util.List; | ||
|
|
||
| @Entity | ||
| public class Label extends AbstractEntity { | ||
|
|
||
| public Label() { | ||
| } | ||
|
|
||
| @OneToMany(mappedBy = "label") | ||
| @OrderBy("id ASC") | ||
| private List<Issue> issue; | ||
|
|
||
| private String name; | ||
|
|
||
| public List<Issue> getIssue() { | ||
| return issue; | ||
| } | ||
|
|
||
| public void setIssue(List<Issue> issue) { | ||
| this.issue = issue; | ||
| } | ||
|
|
||
| public String getName() { | ||
| return name; | ||
| } | ||
|
|
||
| public void setName(String name) { | ||
| this.name = name; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| package codesquad.domain; | ||
|
|
||
| import org.springframework.data.jpa.repository.JpaRepository; | ||
|
|
||
| public interface LabelRepository extends JpaRepository<Label, Long> { | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
생성자를 인스턴스 변수의 수 만큼 생성하고 있는데 좋은 방법은 아님
반드시 필요한 생성자만 추가할 것을 추천