Claude/apply pay period label improvements zs c5e#82
Merged
code-with-jov merged 3 commits intoopsx_pp_13_99from Mar 17, 2026
Merged
Conversation
…ate-range
- Change `getPayPeriodLabel` third parameter from `short: boolean` to
`format: 'picker' | 'summary'` with optional `locale?: Locale`
- Picker format produces `{monthLetter}{withinMonthCount}` (e.g. J1, F2)
using the locale-aware first char of the start month's MMM abbreviation
- Summary format produces `{startDate} - {endDate} (PP{n})` (e.g. Jan 4 - Jan 17 (PP1))
- Update `nameForMonth` in months.ts to forward locale and use new format strings
- Update both BudgetSummary components to use `format='summary'` with locale
- Update unit tests with new expected label formats and add additional coverage
- Update E2E tests to match new summary label regex
https://claude.ai/code/session_018hZh1bX4qEexFQAWDPb1xy
…facts Includes pay-period engine, UI components, budget integration, settings, openspec specs/design files, and opsx command updates that were already present but unstaged. https://claude.ai/code/session_018hZh1bX4qEexFQAWDPb1xy
code-with-jov
commented
Mar 15, 2026
| import * as monthUtils from 'loot-core/shared/months'; | ||
|
|
||
| import { usePayPeriodConfig } from '../PayPeriodContext'; | ||
| import { usePayPeriodConfig } from 'packages/desktop-client/src/components/budget/PayPeriodContext'; |
Owner
Author
There was a problem hiding this comment.
I think this breaks the build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issue(s)
Testing
Checklist