Merged
Conversation
Proposal, design, and tasks for bringing the mobile budget page (BudgetPage, CategoryPage, CategoryTransactions) in line with the desktop pay-period-aware implementation. https://claude.ai/code/session_01C6Li6m7S81FfFebW26gi35
code-with-jov
changed the base branch from
master
to
claude/apply-pay-period-label-improvements-ZsC5e
- BudgetPage: read pay period prefs, build PayPeriodConfig, wrap in PayPeriodProvider; fix currentMonth, prev/next navigation, today button visibility, notes modal label to all pass/use config - MonthSelector: accept payPeriodConfig prop; use getPayPeriodLabel for period display; fix prev/next bounds via period start-date integer comparison against calendar bounds - CategoryPage: build PayPeriodConfig, wrap in PayPeriodProvider, fix header label for pay period IDs - CategoryTransactions: use usePayPeriodConfig() from context; switch getCategoryMonthFilter to date-range filter for pay period IDs https://claude.ai/code/session_01C6Li6m7S81FfFebW26gi35
Auto-fixed by oxlint during lint:fix run. https://claude.ai/code/session_01C6Li6m7S81FfFebW26gi35
code-with-jov
commented
Mar 15, 2026
code-with-jov
commented
Mar 15, 2026
Comment on lines
+1019
to
+1043
| if (payPeriodConfig?.enabled) { | ||
| const prevPeriodId = monthUtils.prevMonth(month, payPeriodConfig); | ||
| const prevPeriodStart = monthUtils.bounds( | ||
| prevPeriodId, | ||
| payPeriodConfig, | ||
| ).start; | ||
| const calendarBoundsStart = monthUtils.bounds(monthBounds.start).start; | ||
| prevEnabled = prevPeriodStart >= calendarBoundsStart; | ||
|
|
||
| const nextPeriodId = monthUtils.nextMonth(month, payPeriodConfig); | ||
| const nextPeriodStart = monthUtils.bounds( | ||
| nextPeriodId, | ||
| payPeriodConfig, | ||
| ).start; | ||
| const calendarBoundsEnd = monthUtils.bounds(monthBounds.end).end; | ||
| nextEnabled = nextPeriodStart <= calendarBoundsEnd; | ||
| } else { | ||
| prevEnabled = month > monthBounds.start; | ||
| nextEnabled = month < monthUtils.subMonths(monthBounds.end, 1); | ||
| } | ||
|
|
||
| const periodLabel = | ||
| isPayPeriod(month) && payPeriodConfig?.enabled | ||
| ? getPayPeriodLabel(month, payPeriodConfig, 'summary', locale) | ||
| : monthUtils.format(month, "MMMM ''yy", locale); |
Owner
Author
There was a problem hiding this comment.
Should some of this be externalized?
code-with-jov
changed the base branch from
claude/apply-pay-period-label-improvements-ZsC5e
to
opsx_pp_13_99
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.