fix(background-agent): cancel all nested descendant tasks recursively #107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
background_cancel(all=true)to recursively cancel ALL nested descendant tasks, not just direct childrenProblem
When calling
background_cancel(all=true), only direct child tasks were being cancelled. Nested tasks (grandchildren, great-grandchildren, etc.) were left orphaned and continued running:Solution
Added
getAllDescendantTasks(sessionID)method that recursively collects all descendant tasks, then updatedbackground_cancelto use this new method.Now all nested tasks are properly cancelled:
Changes
src/features/background-agent/manager.ts- AddedgetAllDescendantTasks()methodsrc/tools/background-task/tools.ts- Updated to use recursive methodsrc/features/background-agent/manager.test.ts- 7 comprehensive testsTesting
🤖 GENERATED WITH ASSISTANCE OF OhMyOpenCode