-
Notifications
You must be signed in to change notification settings - Fork 73
fix: add multimodal-looker to Zod config schema for model overrides #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add multimodal-looker to Zod config schema for model overrides #36
Conversation
The agent was missing from AgentNameSchema and AgentOverridesSchema, causing model overrides in oh-my-opencode.json to be silently dropped. Co-authored-by: Amp <amp@ampcode.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a configuration validation bug where model overrides for the multimodal-looker agent were silently ignored. The agent was implemented and functional, but missing from the Zod config schema, causing the parser to strip its configuration as an unknown property.
Key Changes:
- Added
"multimodal-looker"to theAgentNameSchemaenum insrc/config/schema.tsto allow it in thedisabled_agentslist - Added
"multimodal-looker"property toAgentOverridesSchemainsrc/config/schema.tsto enable per-agent configuration overrides - Updated the corresponding JSON schema in
assets/oh-my-opencode.schema.jsonfor consistency
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/config/schema.ts | Added "multimodal-looker" to AgentNameSchema enum (line 25) and AgentOverridesSchema object (line 69) to enable config validation for the agent |
| assets/oh-my-opencode.schema.json | Added "multimodal-looker" to disabled_agents enum (line 31) and agents propertyNames enum (line 68) to sync JSON schema with Zod schema |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Funny to see ampcode here lool |
|
Seems like you are using ampcode with proxy, what made you still on there? My initial idea was for hackers like you would choose to this because proxy setup is flakey and verbose |
|
lol I add it to get some coauthor achivements by github XD |
lool i should make one then |
I haven’t even graduated yet loll |
because antigravity models from cliproxy is more stable when using in amp, 2 weeks ago they are not even usable in opencode lol. But now they fixed it. I slowly move back to opencode now loll |
it would be def better experience that antigravity support that omo offers. i also experienced that issues you mentioned and i fixed them so.. feel free to enjoy it |
|
Nice. |
Dunno How it can possible through opencode plugin system but i'll look into it. |
Yes in cliproxy, each request will select a different OAuth file |
Problem
Model overrides for the
multimodal-lookeragent inoh-my-opencode.jsonwere silently ignored. Users configuring:{ "agents": { "multimodal-looker": { "model": "cli-proxy-google/gemini-2.5-pro" } } }Would still see the agent use its hardcoded default
google/gemini-2.5-flash.Root Cause
The
multimodal-lookeragent was missing from two Zod schemas insrc/config/schema.ts:AgentNameSchema- validates allowed agent namesAgentOverridesSchema- validates per-agent override configsWhen config was parsed via
OhMyOpenCodeConfigSchema.safeParse(), themultimodal-lookerkey was stripped as an unknown property.Fix
Added
multimodal-lookerto both schemas, aligning the Zod runtime validation with the existing JSON schema (assets/oh-my-opencode.schema.json).