Skip to content

Conversation

@huynguyen03dev
Copy link
Contributor

Problem

Model overrides for the multimodal-looker agent in oh-my-opencode.json were silently ignored. Users configuring:

{
  "agents": {
    "multimodal-looker": {
      "model": "cli-proxy-google/gemini-2.5-pro"
    }
  }
}

Would still see the agent use its hardcoded default google/gemini-2.5-flash.

Root Cause

The multimodal-looker agent was missing from two Zod schemas in src/config/schema.ts:

  • AgentNameSchema - validates allowed agent names
  • AgentOverridesSchema - validates per-agent override configs

When config was parsed via OhMyOpenCodeConfigSchema.safeParse(), the multimodal-looker key was stripped as an unknown property.

Fix

Added multimodal-looker to both schemas, aligning the Zod runtime validation with the existing JSON schema (assets/oh-my-opencode.schema.json).

The agent was missing from AgentNameSchema and AgentOverridesSchema,
causing model overrides in oh-my-opencode.json to be silently dropped.

Co-authored-by: Amp <amp@ampcode.com>
Copilot AI review requested due to automatic review settings December 13, 2025 10:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a configuration validation bug where model overrides for the multimodal-looker agent were silently ignored. The agent was implemented and functional, but missing from the Zod config schema, causing the parser to strip its configuration as an unknown property.

Key Changes:

  • Added "multimodal-looker" to the AgentNameSchema enum in src/config/schema.ts to allow it in the disabled_agents list
  • Added "multimodal-looker" property to AgentOverridesSchema in src/config/schema.ts to enable per-agent configuration overrides
  • Updated the corresponding JSON schema in assets/oh-my-opencode.schema.json for consistency

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/config/schema.ts Added "multimodal-looker" to AgentNameSchema enum (line 25) and AgentOverridesSchema object (line 69) to enable config validation for the agent
assets/oh-my-opencode.schema.json Added "multimodal-looker" to disabled_agents enum (line 31) and agents propertyNames enum (line 68) to sync JSON schema with Zod schema

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@code-yeongyu
Copy link
Owner

Funny to see ampcode here lool

@code-yeongyu
Copy link
Owner

Seems like you are using ampcode with proxy, what made you still on there?

My initial idea was for hackers like you would choose to this because proxy setup is flakey and verbose

@huynguyen03dev
Copy link
Contributor Author

lol I add it to get some coauthor achivements by github XD

@code-yeongyu code-yeongyu merged commit ab522af into code-yeongyu:master Dec 13, 2025
7 checks passed
@code-yeongyu
Copy link
Owner

lol I add it to get some coauthor achivements by github XD

lool i should make one then

@huynguyen03dev
Copy link
Contributor Author

Seems like you are using ampcode with proxy, what made you still on there?

My initial idea was for hackers like you would choose to this because proxy setup is flakey and verbose

I haven’t even graduated yet loll
But yeah opencode feel so much better ampcode, so customizable

@huynguyen03dev huynguyen03dev deleted the fix/multimodal-looker-config-override branch December 13, 2025 11:04
@huynguyen03dev
Copy link
Contributor Author

Seems like you are using ampcode with proxy, what made you still on there?

My initial idea was for hackers like you would choose to this because proxy setup is flakey and verbose

because antigravity models from cliproxy is more stable when using in amp, 2 weeks ago they are not even usable in opencode lol. But now they fixed it. I slowly move back to opencode now loll

@code-yeongyu
Copy link
Owner

Seems like you are using ampcode with proxy, what made you still on there?
My initial idea was for hackers like you would choose to this because proxy setup is flakey and verbose

because antigravity models from cliproxy is more stable when using in amp, 2 weeks ago they are not even usable in opencode lol. But now they fixed it. I slowly move back to opencode now loll

it would be def better experience that antigravity support that omo offers. i also experienced that issues you mentioned and i fixed them so.. feel free to enjoy it

@huynguyen03dev
Copy link
Contributor Author

Nice.
Is antigravity multi-account rotation possible? I think it’s kinda hard.

@code-yeongyu
Copy link
Owner

Nice. Is antigravity multi-account rotation possible? I think it’s kinda hard.

Dunno How it can possible through opencode plugin system but i'll look into it.
do you use that multi account thing?

@huynguyen03dev
Copy link
Contributor Author

Nice. Is antigravity multi-account rotation possible? I think it’s kinda hard.

Dunno How it can possible through opencode plugin system but i'll look into it.

do you use that multi account thing?

Yes in cliproxy, each request will select a different OAuth file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants