Skip to content

[pull] main from dubinc:main #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 2 commits into from
Mar 31, 2026
Merged

[pull] main from dubinc:main #705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f903209
update sortBy for getPartnerCustomersQuerySchema
steven-tey Mar 30, 2026
700531d
Set tsup.config clean: true only on Vercel (#3668)
steven-tey Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 2 additions & 29 deletions ...rs.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/customers/(index)/page-client.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,7 @@ import {
useTable,
} from "@dub/ui";
import { User } from "@dub/ui/icons";
import {
COUNTRIES,
currencyFormatter,
formatDate,
getApexDomain,
getPrettyUrl,
} from "@dub/utils";
import { COUNTRIES, formatDate, getApexDomain, getPrettyUrl } from "@dub/utils";
import { useParams, useRouter } from "next/navigation";
import { useMemo } from "react";
import { usePartnerCustomerFilters } from "./use-partner-customer-filters";
Expand Down Expand Up @@ -64,7 +58,6 @@ export function ProgramCustomersPageClient() {
"customer",
"country",
"link",
"saleAmount",
"createdAt",
"firstSaleAt",
"subscriptionCanceledAt",
Expand All @@ -73,7 +66,6 @@ export function ProgramCustomersPageClient() {
"customer",
"country",
"link",
"saleAmount",
"createdAt",
"firstSaleAt",
"subscriptionCanceledAt",
Expand Down Expand Up @@ -149,25 +141,6 @@ export function ProgramCustomersPageClient() {
),
size: 250,
},
{
id: "saleAmount",
header: "LTV",
meta: {
headerTooltip:
"The total amount of revenue the customer has generated over time (lifetime value).",
},
accessorKey: "activity.saleAmount",
cell: ({ getValue }) => (
<div className="flex items-center gap-2">
<span>
{currencyFormatter(getValue() ?? 0, {
trailingZeroDisplay: "stripIfInteger",
})}
</span>
<span className="text-neutral-400">USD</span>
</div>
),
},
{
id: "createdAt",
header: "Created",
Expand Down Expand Up @@ -270,7 +243,7 @@ export function ProgramCustomersPageClient() {
onPaginationChange: setPagination,
columnVisibility,
onColumnVisibilityChange: setColumnVisibility,
sortableColumns: ["saleAmount", "createdAt"],
sortableColumns: ["createdAt", "firstSaleAt", "subscriptionCanceledAt"],
sortBy,
sortOrder,
onSortChange: ({ sortBy, sortOrder }) =>
Expand Down
2 changes: 1 addition & 1 deletion ...web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/[partnerId]/partner-stats.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export function PartnerStats({
? "-"
: undefined,
href: partner?.id
? `/${slug}/events?event=sales&partnerId=${partner.id}&interval=1y`
? `/${slug}/events?event=sales&partnerId=${partner.id}&interval=1y&saleType=new`
: undefined,
},
{
Expand Down
2 changes: 1 addition & 1 deletion apps/web/lib/zod/schemas/partner-profile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ export const getPartnerCustomersQuerySchema = z
"A filter on the list based on the customer's `linkId` field (the referral link ID).",
),
sortBy: z
.enum(["createdAt", "saleAmount"])
.enum(["createdAt", "firstSaleAt", "subscriptionCanceledAt"])
.optional()
.default("createdAt")
.describe(
Expand Down
2 changes: 1 addition & 1 deletion packages/ui/tsup.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export default defineConfig((options: Options) => ({
},
dts: true,
minify: true,
clean: true,
clean: process.env.VERCEL === "1",
external: ["react"],
...options,
}));
2 changes: 1 addition & 1 deletion packages/utils/tsup.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export default defineConfig((options: Options) => ({
format: ["esm"],
dts: true,
minify: true,
clean: true,
clean: process.env.VERCEL === "1",
external: ["react"],
...options,
}));
Loading