[pull] develop from baserow:develop#268
Merged
Merged
Conversation
* WIP - node history * Add migrations * Fix test * Re-generate migrations * Node history should show result, not payload. * Ensure nested node history scrolls * get_previous_positions() may return None * Fix get_iteration() to use the new iteration_path * The scrollbar should be lighter, hide the background container. * Only show expandable if the node history is completed * Optimize node history endpoint * Return the node type and label from the backend, so that we don't have to lookup published node which the frontend doesn't know about * Use history status icons from design spec * Remove debugging code * Display workflow run error * Don't expand history if workflow is in progress * Find the most specific error * Remove old HistorySection and unused translations * Remove old _NodeHistory.vue, replaced by NodeHistory.vue * Ensure node type label is truncated * Align node type header icon * Ensure Node Explorer's content name is truncated * Add router label to node type, ensure max-width for label * Make sure header expand icon is centered * Truncate error preview * Ensure node result is created when there is an error. This is needed to show the error in the node history. * Lint fix * Ensure parent nodes show error indicator (red text) if child has error. * Clean up styles * Clean up * Handle case when router node has error * Don't render Context or Modal if not final node * Document success_count and fail_count in the API response * When workflow times out, ensure child node histories are also updated. * Remove unused css definitions * Use computed props * Add test to check query count for workflow history * Update test to ensure node history is updated when workflow times out * use a single timezone.now() instance * getNodeType should be a computed prop * getHistoryIconPath should be a computed prop * Add test for node history in api response * Add test for success/fail counts * Add assertion to existing tests to ensure node result is created on workflow error * Update the workflow when a node is modified * Add original_workflow to AutomationWorkflowHistory model, migration, and backfill original_workflow * Delete any published automations that don't have history. * Create a snapshot of the history via publish flow. * Add id to automationnodehistory ordering. Update migrations. * Fix tests * Ensure sample data is saved from snapshot to the draft workflow. * Fix test * Add tests for snapshots * Remove unnecessary guard. * Handle list vs flat result data. * Ensure workflow is updated for snapshot when we CRUD a node. * Make the edge detection more generic. * Add new history_clone workflow state choice * Refactor common logic to new _clone_workflow(). * Simplify async_start_workflow() * Exclude history clones from being deleted during publishing. * Ensure active_published only filters for live workflows * Refactor existing tests + write new ones * Fix test * Add real-time for dispatch start/end, and update history in frontend. * Increase size of the triple-dot link that reveals the Show result button. * Ensure original_workflow is ZDM compatible * Squash local migrations * Simplify * Add spinner when history is loading. * Improve clean_up_previously_published_automations() logic * Use global cache instead of relying on updated_on for cloned workflow. * Rename history clone to test clone. * Create clone only for test, not for simulation. * Update docstring/comments. * Move clone creation to toggle_test_run() * Post-migration fixes * Ensure async_start_workflow() always receives a draf or live workflow. For tests, it should get/create a clone. * Fix state confusion * Add filter to prevent deleting newly created test clone. * Fix test --------- Co-authored-by: Jeremie Pardou <571533+jrmi@users.noreply.github.com>
…ion builder page editor (#5252)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )