[pull] develop from baserow:develop#302
Merged
Merged
Conversation
* Add new skill for creating/updating runtime formulas. * Add abs() formula function * Add getErrorMessage() to arg type to return a human-readable error message. * Update skill to ensure getErrorMessage() is overridden when appropriate. * Add null() runtime formula. * Add number_format() runtime formula. * Fix tests * Add changelog entry * Add date_interval() runtime formula. * Fix test * Add runtime formula: to_datetime() * Update changelog * Fix backend test * Fix frontend test * Add new ensure_date_interval() ensurer. * Update descriptions and examples. * Remove references to Moment.js * Refactor validate_type_of_args() to return the index of the invalid arg. * Refactor to_datetime() to use ensure_datetime() * Use ensure_date_interval ensurer for IntervalStringBaserowRuntimeFormulaArgumentType * Update skill with sections on ensurers. * Add optional strict arg to ensure_datetime() * Fix tests * Simplify the ensure_string() to return total seconds for timedelta. * ensure_date_interval() should also try to convert numbers to a timedelta. * Fix test * Use ensure_integer() in ensure_date_interval() * Rename DateInterval to Duration * Return an array of all possible errors. * Use database duration parser for consistency * Remove contrib references in core. * Add additional test coverage * Rename duration to to_duration * Attempt to fix CI * Reverting some changes * Ensure empty string '' isn't accepted as a datetime format. --------- Co-authored-by: Jeremie Pardou <571533+jrmi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )