Conversation
Fixes #301677 We need to pass the cancellation token as the last param for main thread <-> ext host or else it doesn't get revived, so any callers checking it would fail
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
The disabled Claude Code hooks notification was tracked with a workspace-scoped storage flag that was always set on the first sendRequest call, even when hasDisabledClaudeHooks was false. In the setup agent flow, the user's request is processed by SetupAgent (which calls sendRequestInternal) before the extension is ready. This caused the flag to be set before the real request was resent via chatService.resendRequest. By the time the real request ran, the flag was already true so the hint was silently skipped. Fix: move the storage write inside the hasDisabledClaudeHooks check so the flag is only set when the hint is actually shown. Fixes #295079 Co-authored-by: not-roblourens <78992265+not-roblourens@users.noreply.github.com>
Reapply #301598 with fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )