Conversation
Agent plugin MCP servers did not resolve environment variable references
because the resolution pipeline was skipped entirely (no variableReplacement
was set) and the MCP-standard bare ${VAR} syntax is not recognized by
VS Code's configuration resolver.
- Add variableReplacement to plugin server definitions so the resolution
pipeline runs
- Convert bare ${VAR} references to ${env:VAR} at the plugin boundary
so the resolver can look them up in process.env
Fixes #302579
Replace manual field-by-field cloning with the existing cloneAndChange
utility for a simpler, type-agnostic deep walk that converts bare
${VAR} references to ${env:VAR} in any string value.
…or upstream uri property
cloneAndChange deep-clones objects into plain {} via for...in, which
destroys URI prototype methods. Guard with URI.isUri() to return URI
values unchanged. Also add required uri property to all test definitions
after upstream added IAgentPluginMcpServerDefinition.uri.
* Revert "Add chat session header component and styles" This reverts commit e4c0ce5. * fix compilation
* style: enhance chat bar appearance with margin and background styling Co-authored-by: Copilot <copilot@github.com> * style: adjust padding and margin for title bar and chat bar components * style: adjust chat bar and title bar padding, add border width for layout consistency Co-authored-by: Copilot <copilot@github.com> --------- Co-authored-by: mrleemurray <mrleemurray@users.noreply.github.com> Co-authored-by: Copilot <copilot@github.com>
Fixes #303361 Introduces \\\ variables that extract named capture groups from a task problem matcher's endsPattern and make them available for substitution in launch configurations and other variable-resolved contexts. Changes: - WatchingProblemCollector.tryFinish() extracts matches.groups from endsPattern - IProblemCollectorEvent carries capturedVariables in BackgroundProcessingEnds - TerminalTaskSystem registers captured variables via contributeVariable() - VariableKind.TaskVar added to the enum - Test added for taskVar variable resolution - .vscode/launch.json updated to use \
* feat: enhance GitHub PR handling with headSha support and immediate refresh on session change * feat: implement immediate PR data refresh on active session change * feat: add URI import and enhance session resource handling in GitHubActiveSessionRefreshContribution
…stitution fix(mcp): resolve env vars in agent plugin MCP server definitions
Fix chat overflow toolbar
…304092) When a session is pinned, render a non-clickable pinned icon (Codicon.pinned) in the title row. The icon is hidden on hover/focus when the action bar appears, avoiding visual overlap. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…-panel-animations Revert "Merge pull request #303499 from microsoft/mrleemurray/sessions-panel-animations"
…3971) keyboard: add global flag to macOS layout label replace Co-authored-by: xingsy97 <xingsy97@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )