Conversation
Co-authored-by: astro-security[bot] <astro-security[bot]@users.noreply.github.com>
#15755) * Harden server islands POST endpoint with body size limit * Add security.serverIslandBodySizeLimit and extract shared body-reading utility - Introduce security.serverIslandBodySizeLimit config option so server islands have their own body size limit separate from actions - Extract readBodyWithLimit into a shared utility (core/request-body.ts) used by both actions and server islands, eliminating code duplication - Update server islands endpoint to use the new config and shared utility - Update actions runtime to use the shared utility while preserving ActionError behavior * Fix hanging test: remove reader.cancel() and restore upfront Content-Length check reader.cancel() hangs in Node.js when reading Request body streams in the SSR build context. The original actions code never called it — just throwing from inside the read loop is sufficient. Also restores the upfront Content-Length check in parseRequestBody to match the original control flow. * Improve serverIslandBodySizeLimit JSDoc: fix version, clarify body contents * Update changeset to minor with expanded description --------- Co-authored-by: astro-bot <astro-bot@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com> Co-authored-by: Armand Philippot <git@armand.philippot.eu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )