Skip to content

[pull] main from facebook:main #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 2 commits into from
Mar 5, 2026
Merged

[pull] main from facebook:main #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63ccba8
fix(create-docusaurus): update @types/gtag.js to 0.0.20 (#11770)
fresh3nough Mar 5, 2026
7151555
feat(cli): `write-heading-ids` CLI now supports the `--syntax` option…
slorber Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions packages/docusaurus-mdx-loader/src/remark/headings/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,15 +78,18 @@ function extractCommentId(heading: Heading) {
return undefined;
}

// Try to find an explicit id in the heading text (legacy {#id} syntax)
function extractLegacySyntaxId(heading: Heading, headingText: string) {
const parsedHeading = parseMarkdownHeadingId(headingText);
// Try to find an explicit id in the heading text (classic {#id} syntax)
function extractClassicSyntaxHeadingId(heading: Heading, headingText: string) {
const parsedHeading = parseMarkdownHeadingId(headingText, 'classic');
// Remove the heading text from its id (legacy syntax)
if (parsedHeading.id) {
// When there's an id, it is always in the last child node
const lastNode = heading.children.at(-1) as Text;
if (heading.children.length > 1) {
const lastNodeText = parseMarkdownHeadingId(lastNode.value).text;
const lastNodeText = parseMarkdownHeadingId(
lastNode.value,
'classic',
).text;
// When the last part contains text + id, remove the id
if (lastNodeText) {
lastNode.value = lastNodeText;
Expand Down Expand Up @@ -135,7 +138,7 @@ const plugin: Plugin<PluginOptions[], Root> = function plugin({
function extractIdFromText() {
const headingText = getHeadingText(heading);
return (
extractLegacySyntaxId(heading, headingText) ??
extractClassicSyntaxHeadingId(heading, headingText) ??
slugs.slug(headingText, {maintainCase: anchorsMaintainCase})
);
}
Expand Down
2 changes: 1 addition & 1 deletion packages/docusaurus-plugin-google-gtag/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"@docusaurus/core": "3.9.2",
"@docusaurus/types": "3.9.2",
"@docusaurus/utils-validation": "3.9.2",
"@types/gtag.js": "^0.0.12",
"@types/gtag.js": "^0.0.20",
"tslib": "^2.6.0"
},
"peerDependencies": {
Expand Down
Loading
Loading