[pull] main from expo:main #507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Why Server rendering support was added in #41477 and requires documentation on how to set it up, specifically the new `unstable_useServerRendering` flag that was added to the `expo-router` config plugin. # How Added a new documentation page with a similar flow to the [existing Static Rendering page](https://docs.expo.dev/router/web/static-rendering/). Also updated the Static Rendering page with a link to the new Server Rendering page. There's also a link to a Data Loaders page that doesn't yet exist, this will be addressed in a followup PR. # Test Plan - CI # Checklist - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [x] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) --------- Co-authored-by: Aman Mittal <amandeepmittal@live.com> Co-authored-by: Phil Pluckthun <phil@kitten.sh>
) # Why Update expo-router-plugin to compute EXPO_ROUTER_APP_ROOT relative to the actual file being transformed, rather than the resolved entry file. This fixes monorepos and package managers that hoist expo-router to unexpected locations, such as Bun. # Test Plan - Adds a test case for hoisted package scenarios and removes the resolve-from dependency. --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )