[pull] main from expo:main #541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Why Followup to #42626. As noted [here](#42626 (comment)), the `ImmutableHeaders` type needs to be properly exposed in the public API so it can be used for type annotations. # How Created a new `ImmutableHeaders` type in `types.ts` # Test Plan - CI # Checklist - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
# Why Add documentation for the new bundle diffing feature in EAS Update, which allows for smaller update downloads by delivering only the differences between bundles. # How - Added a new documentation page (`bundle-diffing.mdx`) explaining the feature, prerequisites, setup, and limitations - Added the page to the navigation sidebar in the EAS Update section - Included a screenshot showing how to verify bundle diffs are being served # Test Plan - Verified the new page renders correctly in the documentation site - Confirmed the navigation link works properly - Checked that the image displays correctly on the page # Checklist - [x] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) --------- Co-authored-by: Will Schurman 🦦 <wschurman@expo.io> Co-authored-by: James Ide <ide@expo.dev> Co-authored-by: Aman Mittal <amandeepmittal@live.com>
# Why When running dev-menu as a standalone library, the menu triggers don't work because `currentBridge` is always `null # How Update `ExpoDevMenuReactDelegateHandler` to get the current bridge in `createRootViewController()` instead of `createReactRootView()`. The problem with calling `RCTBridge.current()` in `createReactRootView()` is that the react-native instead is not created at this point yet, always resulting in `RCTBridge.current()` returning null. # Test Plan Install `expo-dev-menu` in mininal tester and remove dev-client then run locally # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
# Why Followup to #42516. After adding the new `requestHeaders()` helper in #42626, RSC projects were unable to use it during development because they weren't using the scoped routing from `expo-server`. # How - Export the RSC routing logic from `createServerComponentsMiddleware()`, and pass it to `createRouteHandlerMiddleware()` instead. - Removed custom request handler for RSC in development, including some related helpers # Test Plan - CI - Manual testing with the `apps/router-e2e/__e2e__/01-rsc` fixture # Checklist - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )