Skip to content

[pull] main from microsoft:main #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 2 commits into from
Dec 11, 2025
Merged

[pull] main from microsoft:main #390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
771d6af
chore: roll driver/Dockerfile to recent Node.js LTS version (#38525)
microsoft-playwright-automation[bot] Dec 11, 2025
4309f5f
Feat/html reporter filter improvements (#38514)
theaniketgiri Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/html-reporter/src/headerView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export const GlobalFilterView: React.FC<{
}>
{icons.search()}
{/* Use navigationId to reset defaultValue */}
<input name='q' spellCheck={false} className='form-control subnav-search-input input-contrast width-full' value={filterText} onChange={e => {
<input name='q' spellCheck={false} className='form-control subnav-search-input input-contrast width-full' aria-label='Search tests' placeholder='Search tests' value={filterText} onChange={e => {
setFilterText(e.target.value);
}}></input>
</form>
Expand Down
30 changes: 15 additions & 15 deletions tests/playwright-test/reporter-html.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1759,7 +1759,7 @@ for (const useIntermediateMergeReport of [true, false] as const) {

await showReport();

const searchInput = page.locator('.subnav-search-input');
const searchInput = page.getByLabel('Search tests');

await expect(page.locator('.test-file-test .label')).toHaveCount(6);
await expect(page.locator('.test-file-test', { has: page.getByText('chromium', { exact: true }) }).locator('.label')).toHaveText(['chromium', 'flaky']);
Expand Down Expand Up @@ -1839,7 +1839,7 @@ for (const useIntermediateMergeReport of [true, false] as const) {

await showReport();

const searchInput = page.locator('.subnav-search-input');
const searchInput = page.getByPlaceholder('Search tests');
const smokeLabelButton = page.locator('.test-file-test', { has: page.getByText('Error Pages › @smoke fails', { exact: true }) }).locator('.label', { hasText: 'smoke' });

await expect(smokeLabelButton).toBeVisible();
Expand Down Expand Up @@ -1916,7 +1916,7 @@ for (const useIntermediateMergeReport of [true, false] as const) {

await showReport();
const tags = ['smoke-p1', 'issue[123]', 'issue#123', '$$$', 'tl/dr'];
const searchInput = page.locator('.subnav-search-input');
const searchInput = page.getByLabel('Search tests');

for (const tag of tags) {
const tagButton = page.locator('.label').getByText(tag, { exact: true });
Expand Down Expand Up @@ -1959,7 +1959,7 @@ for (const useIntermediateMergeReport of [true, false] as const) {

await showReport();
const tags = ['smoke-p1 with other text', 'issue[123] issue[456]', 'issue#123 issue#456', '$$$ ???', 'tl/dr didn\'t read'];
const searchInput = page.locator('.subnav-search-input');
const searchInput = page.getByPlaceholder('Search tests');

for (const tag of tags) {
const tagButton = page.locator('.label').getByText(tag, { exact: true });
Expand Down Expand Up @@ -2003,7 +2003,7 @@ for (const useIntermediateMergeReport of [true, false] as const) {

await showReport();

const searchInput = page.locator('.subnav-search-input');
const searchInput = page.getByLabel('Search tests');

const smokeLabelButton = page.locator('.test-file-test', { has: page.getByText('@smoke fails', { exact: true }) }).locator('.label', { hasText: 'smoke' });
await smokeLabelButton.click();
Expand Down Expand Up @@ -2070,7 +2070,7 @@ for (const useIntermediateMergeReport of [true, false] as const) {
return total;
}

const searchInput = page.locator('.subnav-search-input');
const searchInput = page.getByPlaceholder('Search tests');
await expect(page.getByTestId('filtered-tests-count')).not.toBeVisible();
await expect(page.getByTestId('overall-duration')).toHaveText(`Total time: ${msToString(result.report.stats.duration)}`);

Expand Down Expand Up @@ -2132,7 +2132,7 @@ for (const useIntermediateMergeReport of [true, false] as const) {

await showReport();

const searchInput = page.locator('.subnav-search-input');
const searchInput = page.getByLabel('Search tests');
const passedNavMenu = page.locator('.subnav-item:has-text("Passed")');
const failedNavMenu = page.locator('.subnav-item:has-text("Failed")');
const allNavMenu = page.locator('.subnav-item:has-text("All")');
Expand Down Expand Up @@ -2198,7 +2198,7 @@ for (const useIntermediateMergeReport of [true, false] as const) {

await showReport();

const searchInput = page.locator('.subnav-search-input');
const searchInput = page.getByPlaceholder('Search tests');

await searchInput.fill('@smoke');
await searchInput.press('Enter');
Expand Down Expand Up @@ -2267,7 +2267,7 @@ for (const useIntermediateMergeReport of [true, false] as const) {
await expect(page.locator('.test-file-test .test-file-title', { hasText: '@company_information fails' })).toHaveCount(1);
await expect(page.locator('.test-file-test .test-file-title', { hasText: '@company_information_widget fails' })).toHaveCount(1);

const searchInput = page.locator('.subnav-search-input');
const searchInput = page.getByLabel('Search tests');
const companyLabelButton = page.locator('.test-file-test', { has: page.getByText('@company passes') }).locator('.label', { hasText: 'company' });
const companyInformationLabelButton = page.locator('.test-file-test', { has: page.getByText('@company_information fails') }).locator('.label', { hasText: 'company_information' });
const companyInformationWidgetLabelButton = page.locator('.test-file-test', { has: page.getByText('@company_information_widget fails') }).locator('.label', { hasText: 'company_information_widget' });
Expand Down Expand Up @@ -2337,7 +2337,7 @@ for (const useIntermediateMergeReport of [true, false] as const) {
const smokeButton = page.locator('.label', { hasText: 'smoke' }).first();
const regressionButton = page.locator('.label', { hasText: 'regression' }).first();
const flakyButton = page.locator('.label', { hasText: 'flaky' }).first();
const searchInput = page.locator('.subnav-search-input');
const searchInput = page.getByPlaceholder('Search tests');

await expect(page.locator('.chip')).toHaveCount(3);
await expect(page.locator('.chip', { hasText: 'a.test.js' })).toHaveCount(1);
Expand Down Expand Up @@ -2480,7 +2480,7 @@ for (const useIntermediateMergeReport of [true, false] as const) {
await expect(page.locator('.test-file-test .label').getByText('Monitoring', { exact: true })).toHaveCount(3);
await expect(page.locator('.test-file-test .label').getByText('Notifications', { exact: true })).toHaveCount(3);

const searchInput = page.locator('.subnav-search-input');
const searchInput = page.getByLabel('Search tests');

const monitoringLabelButton = page.locator('.label').getByText('Monitoring', { exact: true });
await monitoringLabelButton.first().click();
Expand Down Expand Up @@ -2619,7 +2619,7 @@ for (const useIntermediateMergeReport of [true, false] as const) {

await showReport();

const searchInput = page.locator('.subnav-search-input');
const searchInput = page.getByPlaceholder('Search tests');

await searchInput.fill('file-a');
await expect(page.getByText('file-a.test.js', { exact: true })).toBeVisible();
Expand Down Expand Up @@ -2669,7 +2669,7 @@ for (const useIntermediateMergeReport of [true, false] as const) {

await showReport();

const searchInput = page.locator('.subnav-search-input');
const searchInput = page.getByLabel('Search tests');

await searchInput.fill('s:failed');
await expect(page.getByText('a.test.js', { exact: true })).toBeVisible();
Expand Down Expand Up @@ -2698,7 +2698,7 @@ for (const useIntermediateMergeReport of [true, false] as const) {

await showReport();

const searchInput = page.locator('.subnav-search-input');
const searchInput = page.getByPlaceholder('Search tests');

await test.step('filter by type and value', async () => {
await searchInput.fill('annot:key=value');
Expand Down Expand Up @@ -2749,7 +2749,7 @@ for (const useIntermediateMergeReport of [true, false] as const) {

await showReport();

const searchInput = page.locator('.subnav-search-input');
const searchInput = page.getByLabel('Search tests');

await searchInput.fill('a.test.js:3:11');
await expect(page.getByText('a.test.js:3', { exact: true })).toBeVisible();
Expand Down
2 changes: 1 addition & 1 deletion utils/build/build-playwright-driver.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -x

trap "cd $(pwd -P)" EXIT
SCRIPT_PATH="$(cd "$(dirname "$0")" ; pwd -P)"
NODE_VERSION="24.11.1" # autogenerated via ./update-playwright-node.mjs
NODE_VERSION="24.12.0" # autogenerated via ./update-playwright-node.mjs

cd "$(dirname "$0")"
PACKAGE_VERSION=$(node -p "require('../../package.json').version")
Expand Down
Loading