Conversation
* fix: avoid triggering onClick on disabled links * add link specific test and fix event order * remove unneeded code --------- Co-authored-by: Robert Snow <rsnow@adobe.com> Co-authored-by: Robert Snow <snowystinger@gmail.com>
…orybook (#8844) * chore: remove argTypesRegex and explicitly pass actions in s2 storybook * clean up
Co-authored-by: 印南雄悟 <> Co-authored-by: Yihui Liao <44729383+yihuiliao@users.noreply.github.com>
…art (#8815) * fix: iso8601 week start and use intl.locale when possible for week start * add fw override * fix lint * fix merge --------- Co-authored-by: Yihui Liao <44729383+yihuiliao@users.noreply.github.com>
* fix: popover positioning * fix the position * add pending state to action buttons * support a default label slot in s2 picker * make it so cell focus ring is always on top of the content * actually disable interactions on buttons in pending state, including through context * fix lint * fix more lint * fix ActionButton avatar visibility during pending * fix lint for real * fix lint for real__FINAL * SelectBoxGroup shouldn't lose focus ring for mouse like checkbox/radio don't * fix lint... * fix lint and remove extra console log * fix tests by making them more realistic * leave focus events on pending button alone * Add delays * longer delay? and click body first? * click body before on mobile as well * cleanup extraneous timeouts * scuffed fix, figure out if we should be flipping other instances of containerOffsetWithBoundary * make story more useful * more half fixes for positioning * fix import * fix overlay position!!!!! * fix html as the container * fix scrolled case --------- Co-authored-by: Daniel Lu <dl1644@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )