split grpc server into static and dynamic server#317
Merged
raphael-goetz merged 5 commits into#311-new-module-endpointfrom Apr 30, 2026
Merged
split grpc server into static and dynamic server#317raphael-goetz merged 5 commits into#311-new-module-endpointfrom
raphael-goetz merged 5 commits into#311-new-module-endpointfrom
Conversation
GitLab Pipeline ActionGeneral informationLink to pipeline: https://gitlab.com/code0-tech/development/aquila/-/pipelines/2491579692 Status: Passed Job summariesdocs:previewDocumentation preview available at https://code0-tech.gitlab.io/-/development/telescopium/-/jobs/14163781268/artifacts/out/index.html |
This was
linked to
issues
Apr 30, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Splits Aquila’s gRPC server startup into distinct static vs dynamic mode servers, and updates dynamic mode to initiate the Sagittarius execution (test) stream to align with the latest tucana interface.
Changes:
- Introduces
AquilaStaticServerandAquilaDynamicServer, moving mode-specific server bootstrapping intostatic_modeanddynamic_mode. - Adds initialization/reconnect loop for the Sagittarius test execution stream in dynamic mode.
- Improves logging and token-safe observability (masked tokens), plus refactors readiness interception into a reusable interceptor helper.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/startup/static_mode.rs | Static-mode startup now loads fallback flows and starts a static-only gRPC server. |
| src/startup/mod.rs | Startup now selects static vs dynamic mode and passes shared NATS/KV dependencies into each mode. |
| src/startup/dynamic_mode.rs | Dynamic-mode startup now creates the dynamic gRPC server and spawns Sagittarius flow + test execution stream tasks. |
| src/server/static_server.rs | New static gRPC server implementation (action transfer + optional health). |
| src/server/dynamic_server.rs | New dynamic gRPC server implementation (module/runtime services + action transfer + optional health). |
| src/server/mod.rs | Removes monolithic server; exposes dynamic_server, static_server, and shared interceptor. |
| src/server/interceptor.rs | New shared readiness interceptor helper used by both server types. |
| src/server/action_transfer_service_server_impl.rs | Logging improvements and token masking for action transfer stream. |
| src/server/module_service_server_impl.rs | Adds token-masked auth rejection logs and clearer debug logging. |
| src/server/runtime_status_service_server_impl.rs | Adds token-masked auth rejection logs and clearer debug logging. |
| src/server/runtime_usage_service_server_impl.rs | Adds token-masked auth rejection logs and clearer debug logging. |
| src/sagittarius/test_execution_client_impl.rs | Refactors execution client construction to accept a Channel and adds auth metadata to streaming request. |
| src/sagittarius/retry.rs | Adds structured logging around Sagittarius dial/retry attempts. |
| src/sagittarius/module_service_client_impl.rs | Adds structured logging (module counts, rejection reason). |
| src/sagittarius/runtime_status_service_client_impl.rs | Adds structured logging and reduces severity for “unsuccessful” responses. |
| src/sagittarius/runtime_usage_client_impl.rs | Adds structured logging (sample counts) and reduces severity for “unsuccessful” responses. |
| src/main.rs | Adjusts logging defaults and adds config debug logging. |
| src/configuration/mod.rs | Reorders module declarations (no functional impact). |
| src/authorization/mod.rs | Adds mask_token and improves auth header parsing logs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #299 & #310