Skip to content

Custom Header Input #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raphael-goetz merged 2 commits into from
Dec 19, 2025
Merged

Custom Header Input #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbd5900
feat: added http header input
raphael-goetz Dec 19, 2025
4ab6eaf
ref: moved http adapter input back into http feature
raphael-goetz Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions definitions/http/data_type/http.header_input.proto.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
{
"variant": "OBJECT",
Copy link
Contributor

@nicosammito nicosammito Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally this change it ok, but I thought about declaring this of type object but not linking it to object. I think we should discuss the field variant. In my opinion is unnecessary.

"identifier": "HTTP_HEADER_INPUT",
"name": [
{
"code": "en-US",
"content": "HTTP Headers"
}
],
"alias": [
{
"code": "en-US",
"content": "http;header;entry;input"
}
],
"displayMessage": [
{
"code": "en-US",
"content": "HTTP Headers"
}
],
"rules": [],
"genericKeys": []
}
26 changes: 13 additions & 13 deletions ...type/object/http_adapter_input.proto.json → ...p/data_type/http_adapter_input.proto.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,18 @@
"content": "HTTP Adapter Input"
}
],
"alias": [
{
"code": "en-US",
"content": "http;adapter;input"
}
],
"displayMessage": [
{
"code": "en-US",
"content": "HTTP Adapter Input"
}
],
"alias": [
{
"code": "en-US",
"content": "http;adapter;input"
}
],
"displayMessage": [
{
"code": "en-US",
"content": "HTTP Adapter Input"
}
],
"rules": [
{
"containsKey": {
Expand All @@ -32,7 +32,7 @@
"containsKey": {
"key": "headers",
"dataTypeIdentifier": {
"dataTypeIdentifier": "HTTP_HEADER_MAP"
"dataTypeIdentifier": "HTTP_HEADER_INPUT"
}
}
},
Expand Down