Skip to content

New Type for Variants (Also for sizes now) #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Feb 24, 2024
Merged

New Type for Variants (Also for sizes now) #66

merged 19 commits into from
Feb 24, 2024

Conversation

@Knerio
Copy link
Member

@Knerio Knerio commented Feb 17, 2024 •
edited
Loading

This would resolve #50

With d61bda0 there are also sizes like xs, md and xl etc

@Knerio Knerio self-assigned this Feb 17, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2024 •
edited
Loading

GitLab Pipeline Action

General information

Link to pipeline: https://gitlab.com/code0-tech/development/pictor/-/pipelines/1189293806

Status: Passed
Duration: 4 minutes

Job summaries

docs:preview

Documentation preview available at https://code0-tech.gitlab.io/-/development/telescopium/-/jobs/6249227456/artifacts/dist/index.html

storybook:build

Storybook available at https://code0-tech.gitlab.io/-/development/pictor/-/jobs/6249222748/artifacts/storybook-static/index.html

@Knerio Knerio added enhancement New feature or request regenerate-snapshots Starts a pipeline to regenerate image snapshots labels Feb 17, 2024
@Taucher2003 Taucher2003 removed the regenerate-snapshots Starts a pipeline to regenerate image snapshots label Feb 17, 2024
@Knerio Knerio requested review from Taucher2003 and nicosammito and removed request for nicosammito February 17, 2024 23:17
nicosammito
nicosammito previously requested changes Feb 18, 2024
View reviewed changes
Copy link
Contributor

@nicosammito nicosammito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall nicely done, but as you see in #59 we are changing from Variant to Color, because Variant is used differently now

@Knerio
Copy link
Member Author

Knerio commented Feb 18, 2024

Overall nicely done, but as you see in #59 we are changing from Variant to Color, because Variant is used differently now

Thats true, but in #64 that would be a problem

@Knerio
Copy link
Member Author

Knerio commented Feb 18, 2024

Overall nicely done, but as you see in #59 we are changing from Variant to Color, because Variant is used differently now

Thats true, but in #64 that would be a problem

Or we could implement these styles but we also need to fix the @include box then for all the new variants

@nicosammito
Copy link
Contributor

Overall nicely done, but as you see in #59 we are changing from Variant to Color, because Variant is used differently now

Thats true, but in #64 that would be a problem

Yeh we need to change this in all components from now on. Just change variant: “bla” | “bla” to color: “bla” | “bla”

@Knerio Knerio requested a review from nicosammito February 18, 2024 14:43
@Knerio Knerio mentioned this pull request Feb 18, 2024
Closed
@Knerio Knerio changed the title New Type for Variants New Type for Variants (Also for sizes now) Feb 18, 2024
nicosammito
nicosammito requested changes Feb 18, 2024
View reviewed changes
@Knerio Knerio requested a review from nicosammito February 19, 2024 16:09
@Knerio Knerio added the regenerate-snapshots Starts a pipeline to regenerate image snapshots label Feb 19, 2024
@github-actions github-actions bot removed the regenerate-snapshots Starts a pipeline to regenerate image snapshots label Feb 19, 2024
nicosammito
nicosammito requested changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@nicosammito nicosammito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor changes before we can merge

@Knerio Knerio requested a review from nicosammito February 20, 2024 15:16
nicosammito
nicosammito requested changes Feb 20, 2024
View reviewed changes
@Knerio Knerio requested a review from nicosammito February 20, 2024 20:43
nicosammito
nicosammito previously approved these changes Feb 24, 2024
View reviewed changes
Copy link
Contributor

@nicosammito nicosammito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done

@nicosammito nicosammito added the regenerate-snapshots Starts a pipeline to regenerate image snapshots label Feb 24, 2024
@github-actions github-actions bot removed the regenerate-snapshots Starts a pipeline to regenerate image snapshots label Feb 24, 2024
@nicosammito nicosammito self-requested a review February 24, 2024 13:58
@Knerio Knerio merged commit fdcf270 into main Feb 24, 2024
@nicosammito nicosammito deleted the variants branch March 4, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicosammito nicosammito nicosammito approved these changes

@Taucher2003 Taucher2003 Awaiting requested review from Taucher2003

Assignees

@Knerio Knerio

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Type for all available variants

4 participants

@Knerio @nicosammito @Taucher2003