Skip to content

Merge Props for components #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 30, 2024
Merged

Merge Props for components #84

merged 6 commits into from
Apr 30, 2024

Conversation

@nicosammito
Copy link
Contributor

No description provided.

@nicosammito nicosammito added the enhancement New feature or request label Apr 30, 2024
@nicosammito nicosammito self-assigned this Apr 30, 2024
@nicosammito nicosammito added the regenerate-snapshots Starts a pipeline to regenerate image snapshots label Apr 30, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Apr 30, 2024 •
edited
Loading

GitLab Pipeline Action

General information

Link to pipeline: https://gitlab.com/code0-tech/development/pictor/-/pipelines/1273995111

Status: Passed
Duration: 4 minutes

Job summaries

docs:preview

Documentation preview available at https://code0-tech.gitlab.io/-/development/telescopium/-/jobs/6753262684/artifacts/dist/index.html

storybook:build

Storybook available at https://code0-tech.gitlab.io/-/development/pictor/-/jobs/6753255806/artifacts/storybook-static/index.html

@nicosammito nicosammito removed the regenerate-snapshots Starts a pipeline to regenerate image snapshots label Apr 30, 2024
@nicosammito nicosammito requested a review from Taucher2003 April 30, 2024 20:57
@nicosammito nicosammito added the regenerate-snapshots Starts a pipeline to regenerate image snapshots label Apr 30, 2024
@github-actions github-actions bot removed the regenerate-snapshots Starts a pipeline to regenerate image snapshots label Apr 30, 2024
Taucher2003
Taucher2003 approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@Taucher2003 Taucher2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a detailed understanding, but the pipeline passes and the changes are consistent across the components, so this is probably fine

@nicosammito nicosammito merged commit 9e4af8e into main Apr 30, 2024
@nicosammito nicosammito deleted the props-merging branch April 30, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Taucher2003 Taucher2003 Taucher2003 approved these changes

Assignees

@nicosammito nicosammito

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nicosammito @Taucher2003