correct mutation connection#1004
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the GraphQL mutation response shape for updating a runtime assignment’s module configurations (per #1003) by returning the updated module configurations directly, aligning service payloads, tests, and generated documentation.
Changes:
- Update the service to return persisted
ModuleConfigurationrecords as the success payload. - Update the GraphQL mutation to expose
moduleConfigurations(list) instead ofnamespaceProjectRuntimeAssignment. - Update request/service specs and GraphQL mutation docs to match the new response shape.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| spec/services/namespaces/projects/runtime_assignments/update_module_configurations_service_spec.rb | Adjusts expectations to match the service now returning module configuration records. |
| spec/requests/graphql/mutation/namespace/projects/runtime_assignments/update_module_configurations_mutation_spec.rb | Updates the mutation query and assertions to validate the new moduleConfigurations response. |
| docs/graphql/mutation/namespacesprojectsruntimeassignmentsupdatemoduleconfigurations.md | Updates documented mutation fields to reflect returning moduleConfigurations. |
| app/services/namespaces/projects/runtime_assignments/update_module_configurations_service.rb | Returns db_configurations as the ServiceResponse payload. |
| app/graphql/mutations/namespaces/projects/runtime_assignments/update_module_configurations.rb | Changes the mutation’s success field and to_mutation_response key to module_configurations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
GitLab Pipeline ActionGeneral informationLink to pipeline: https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2570849448 Status: Passed Job summariesrspec: [cloud]Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/14656668853/artifacts/tmp/coverage/index.html rspec: [ee]Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/14656668852/artifacts/tmp/coverage/index.html rspec: [ce]Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/14656668851/artifacts/tmp/coverage/index.html docs:previewDocumentation preview available at https://code0-tech.gitlab.io/-/development/telescopium/-/jobs/14656736714/artifacts/out/index.html rubocop866 files inspected, no offenses detected |
Resolves: #1003