Skip to content

correct mutation connection#1004

Merged
Taucher2003 merged 1 commit into
mainfrom
#1003-correct-module-mutations
Jun 2, 2026
Merged

correct mutation connection#1004
Taucher2003 merged 1 commit into
mainfrom
#1003-correct-module-mutations

Conversation

@raphael-goetz
Copy link
Copy Markdown
Member

Resolves: #1003

Copilot AI review requested due to automatic review settings June 2, 2026 15:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the GraphQL mutation response shape for updating a runtime assignment’s module configurations (per #1003) by returning the updated module configurations directly, aligning service payloads, tests, and generated documentation.

Changes:

  • Update the service to return persisted ModuleConfiguration records as the success payload.
  • Update the GraphQL mutation to expose moduleConfigurations (list) instead of namespaceProjectRuntimeAssignment.
  • Update request/service specs and GraphQL mutation docs to match the new response shape.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
spec/services/namespaces/projects/runtime_assignments/update_module_configurations_service_spec.rb Adjusts expectations to match the service now returning module configuration records.
spec/requests/graphql/mutation/namespace/projects/runtime_assignments/update_module_configurations_mutation_spec.rb Updates the mutation query and assertions to validate the new moduleConfigurations response.
docs/graphql/mutation/namespacesprojectsruntimeassignmentsupdatemoduleconfigurations.md Updates documented mutation fields to reflect returning moduleConfigurations.
app/services/namespaces/projects/runtime_assignments/update_module_configurations_service.rb Returns db_configurations as the ServiceResponse payload.
app/graphql/mutations/namespaces/projects/runtime_assignments/update_module_configurations.rb Changes the mutation’s success field and to_mutation_response key to module_configurations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

GitLab Pipeline Action

General information

Link to pipeline: https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2570849448

Status: Passed
Duration: 6 minutes

Job summaries

rspec: [cloud]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/14656668853/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2570849448/test_report
Finished in 27.82 seconds (files took 12.8 seconds to load)
1509 examples, 0 failures
Line Coverage: 92.98% (5257 / 5654)
[TEST PROF INFO] Time spent in factories: 00:16.862 (49.44% of total time)

rspec: [ee]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/14656668852/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2570849448/test_report
Finished in 24.77 seconds (files took 12.45 seconds to load)
1473 examples, 0 failures
Line Coverage: 93.19% (5104 / 5477)
[TEST PROF INFO] Time spent in factories: 00:15.482 (47.94% of total time)

rspec: [ce]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/14656668851/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2570849448/test_report
Finished in 26.8 seconds (files took 12.91 seconds to load)
1423 examples, 0 failures
Line Coverage: 92.72% (4928 / 5315)
[TEST PROF INFO] Time spent in factories: 00:16.195 (47.86% of total time)

docs:preview

Documentation preview available at https://code0-tech.gitlab.io/-/development/telescopium/-/jobs/14656736714/artifacts/out/index.html

rubocop

866 files inspected, no offenses detected

@Taucher2003 Taucher2003 merged commit 927d465 into main Jun 2, 2026
2 checks passed
@Taucher2003 Taucher2003 deleted the #1003-correct-module-mutations branch June 2, 2026 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Correct Module Config Mutation

3 participants