Skip to content

Conversation

@Knerio
Copy link
Member

@Knerio Knerio commented Nov 18, 2025

close #658

@Knerio Knerio self-assigned this Nov 18, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot finished reviewing on behalf of Knerio November 18, 2025 17:28
@github-actions
Copy link

github-actions bot commented Nov 18, 2025

GitLab Pipeline Action

General information

Link to pipeline: https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2165943388

Status: Passed
Duration: 4 minutes

Job summaries

rspec: [ee]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/12132914432/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2165943388/test_report
Finished in 20.84 seconds (files took 10.3 seconds to load)
1189 examples, 0 failures
Line Coverage: 91.32% (4039 / 4423)
[TEST PROF INFO] Time spent in factories: 00:11.170 (42.02% of total time)

rspec: [ce]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/12132914431/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2165943388/test_report
Finished in 24.79 seconds (files took 12.97 seconds to load)
1142 examples, 0 failures
Line Coverage: 90.7% (3871 / 4268)
[TEST PROF INFO] Time spent in factories: 00:13.528 (41.86% of total time)

rubocop

670 files inspected, no offenses detected

@Knerio Knerio force-pushed the 658-nodefunctioninput-should-contain-the-nextnodeid-instead-of-the-full-nodefunction branch from bbb65e2 to 1ae56ca Compare November 18, 2025 19:35
@Knerio Knerio requested a review from Copilot November 18, 2025 19:36
Copilot finished reviewing on behalf of Knerio November 18, 2025 19:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Knerio Knerio force-pushed the 658-nodefunctioninput-should-contain-the-nextnodeid-instead-of-the-full-nodefunction branch from 1ae56ca to 65a41ba Compare November 18, 2025 19:41
@code0-tech code0-tech deleted a comment from Copilot AI Nov 18, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Dario Pranjic <96529060+Knerio@users.noreply.github.com>
Copy link
Member

@Taucher2003 Taucher2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the whole Flows::CreateService needs refactoring. Especially the SagittariusSchema.object_from_id calls and not every created object is correctly linked to its owning runtime.

But to unblock Sculptor, this is currently fine. This will however have to be updated before the MVP release because I feel like this is a vulnerability waiting to happen.

@Taucher2003 Taucher2003 merged commit 4e14e2a into main Nov 18, 2025
1 check passed
@Taucher2003 Taucher2003 deleted the 658-nodefunctioninput-should-contain-the-nextnodeid-instead-of-the-full-nodefunction branch November 18, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NodeFunctionInput should contain the nextNodeId instead of the full NodeFunction

3 participants