-
Notifications
You must be signed in to change notification settings - Fork 0
NodeFunctionInput contains nextNodeId instead of the whole node #702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NodeFunctionInput contains nextNodeId instead of the whole node #702
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
GitLab Pipeline ActionGeneral informationLink to pipeline: https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2165943388 Status: Passed Job summariesrspec: [ee]Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/12132914432/artifacts/tmp/coverage/index.html rspec: [ce]Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/12132914431/artifacts/tmp/coverage/index.html rubocop670 files inspected, no offenses detected |
bbb65e2 to
1ae56ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
spec/requests/graphql/mutation/namespace/projects/flows/create_mutation_spec.rb
Show resolved
Hide resolved
spec/requests/graphql/mutation/namespace/projects/flows/create_mutation_spec.rb
Show resolved
Hide resolved
1ae56ca to
65a41ba
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Dario Pranjic <96529060+Knerio@users.noreply.github.com>
Taucher2003
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the whole Flows::CreateService needs refactoring. Especially the SagittariusSchema.object_from_id calls and not every created object is correctly linked to its owning runtime.
But to unblock Sculptor, this is currently fine. This will however have to be updated before the MVP release because I feel like this is a vulnerability waiting to happen.
close #658